STDIN not working properly with OS X about childprocess HOT 10 CLOSED

Also, this is with 0.4.1

from childprocess.

Right it's a regression in 0.4.1. Looking into it.

from childprocess.

Thanks. Let me know if I can help in any way, I tried to investigate further but couldn't figure it out.

from childprocess.

The problem is essentially that we're now (since 0.4.1) letting the child process have it's own process group. This was done to fix issue #66 / #67, but it breaks tty/stdin like you point out.

I tried experimenting with tcsetpgrp(3), but couldn't make it work. I'll take another stab at it tomorrow.

Also need to find a way to spec this that doesn't involve manual typing into the terminal.

from childprocess.

HAHAH (at your last sentence).

As an interim, could we have an option to not create a new process group?

from childprocess.

OK - this should now work on master:

p = ChildProcess.build("ruby", "-e", "p STDIN.tty?; p STDIN.gets")
p.io.inherit!
p.keep_pgid = true if p.kind_of?(ChildProcess::Unix::Process)
p.start
p.wait

I'd really like to keep platform-specific options out of the API, so hopefully it'll be gone ASAP :)

from childprocess.

I totally understand. I don't know if you would mind maybe scoping it to note that it is temporary and cutting a release with it? I can do a #respond_to? check on it but require it for some upcoming things (and require the fixes in 0.4.1).

Thanks!

from childprocess.

All right, pushed as 0.4.2.

from childprocess.

I've pushed 0.5.0 which removes the keep_pgid flag and reverts the default behaviour to what it was pre 0.4.1.

Anyone who wants the 0.4.1-0.4.2 behaviour must explicitly enable it:

proc = ChildProcess.build(...)
proc.leader = true
proc.start

from childprocess.

I agree this is the correct solution. Thank you!

from childprocess.