Ruby 3.0 support about childprocess HOT 10 CLOSED

It seems that the problem might be some race condition, since this works:

$ rspec ./spec/io_spec.rb
..........

Finished in 0.79139 seconds (files took 0.07509 seconds to load)
10 examples, 0 failures

from childprocess.

Ah, forgot to include the CHILDPROCESS_POSIX_SPAWN=true, so it doesn't work indeed.

from childprocess.

This was the last successful build:

https://travis-ci.org/github/enkessler/childprocess/jobs/687662868

and this is where the issue first appeared:

https://travis-ci.org/github/enkessler/childprocess/jobs/698756797

from childprocess.

So the cat: -: Resource temporarily unavailable is reported from here:

called from here:

Checking what was changed in Ruby, this is susceptible commit:

ruby/ruby@0e3b0fc

But that might be completely false lead 😇

from childprocess.

This seems to be the root cause, the change from RUBY_PIPE_NONBLOCK_DEFAULT, which was 0, to O_NONBLOCK. I have locally replaced the O_NONBLOCK by 0 and the test suite passes.

Unfortunately, other test case fails then:

  1) ChildProcess lets a detached child live on
     Failure/Error: expect(alive?(c_pid)).to be true
     
       expected true
            got false
     # ./spec/childprocess_spec.rb:214:in `block (2 levels) in <top (required)>'

from childprocess.

I have reported this against Ruby:

https://bugs.ruby-lang.org/issues/17607

from childprocess.

I wonder if #172 / #175 might solve this. At least CHILDPROCESS_UNSET=should-be-unset bundle exec rake passes for me on that PR with Ruby 3.0.0.

from childprocess.

Confirmed that #175 (comment) actually fixes the CI on ruby-head (the only ruby-head CI failing is then due to installing FFI, which is unrelated and no longer needed with that PR).

from childprocess.

Thx, the test suite passes with #175. Nevertheless, I'd still like to also understand the reasons why it started to fail, although it will have smaller priority 😇

from childprocess.

Closed by #175.

from childprocess.