Support environmental variables about childprocess HOT 7 CLOSED

Note at the moment I'm using this little helper method to work around this:

    # This method changes the environmental variables of the process to
    # that of this environment, yields, and then resets them. This allows
    # us to change the environment temporarily.
    def with_env_changes
      stashed = {}

      begin
        @env.each do |key, value|
          stashed[key] = ENV[key]
          ENV[key] = value
        end

        yield
      ensure
        stashed.each do |key, value|
          ENV[key] = stashed[key]
        end
      end
    end

Then using it like so:

process = ChildProcess.build("blah", "blah")
with_env_changes do
  process.start
end

And this gets around the issue since all platforms I believe inherit environmental variables. However, it seems hacky and isn't threadsafe and pushes a lot of that logic down to the client, whereas environmental variables are a first class argument in any exec type API, so I think it should be in ChildProcess as well. :)

from childprocess.

I agree. I'll see what I can do.

from childprocess.

Does that look ok to you?

Right now the child process will inherit the parent's environment when you call #start, which I think makes sense. One could argue that we should store a copy of the parent environment when ChildProces.build is called instead. Thoughts?

from childprocess.

Looks very good! I see you properly got the edge-cases that Java and Windows have of SETTING the environment instead of setting overrides for the current environment, which is the only thing I knew to look for in this change.

As for when to set the environment, I think start is the right place. All "fork-like" APIs do the actual environment copy on fork, so I think doing it on "start" for childprocess makes sense.

Thank you!

When will there be a gem push? :)

from childprocess.

Pushed!

from childprocess.

Thank you for the quick turnaround on this. Be proud you have the best subprocess library for Ruby hands down.

from childprocess.

Thanks :)

from childprocess.