eneko89 / cachekill Goto Github PK

after usage, one image got a wrong replacing.

in the folder the image ist called:
placeholder-valentin-f956d81ec00f7b2e5592ade6fe9f2983.webp

in the html file it was replaced with:
placeholder-valentin-f956d81ec00f7b2e5592ade6fe9f2983-ef63272fee16e03b4c225a575f56864d.webp

Steps to reproduce the bug

Download one page of my website and all its assets with the command

wget -E -k -K -p https://www.mathebibel.de

Open the folder ẁww.mathebibel.de and run the command

cachekill -l 16 -r -p '{name}.{hash}{ext}' -s '**/*.{svg,jpg,jpeg,png,ico,ttf,woff,woff2}' -t '**/*.{html,css,js,webmanifest}'

Open the file index.html and search for da5a9c97d2054b2a.

You will get the following 6 hits:

1. bilder/logo.da5a9c97d2054b2a.png
2. awards/gpi-logo.da5a9c97d2054b2a.png
3. awards/stern-logo.da5a9c97d2054b2a.png
4. awards/ntv-logo.da5a9c97d2054b2a.png
5. bilder/logo.da5a9c97d2054b2a.png
6. bilder/easy-tutor-logo.da5a9c97d2054b2a.png

Number 1 and 5 are correct replacements. Number 2, 3, 4 and 6 are wrong replacements.

This was just an example. You can find even more wrong replacements in the index.html.

First of all thanks for the time you spent in this project. It really fits my needs at the moment:)

When i use the tool and use one reference on two points, it always changes only the first one.
(So when i have 1 picture that i call on two places of the page, the link in the is css only search and replaced by one of them.
So 1 picture still links to the old name)
In the documentation of "replace-in-file" they talk about a regex which is need: https://www.npmjs.com/package/replace-in-file#replace-all-occurrences
Would be in line 129 of your code if i am correct.

Issue

If the pattern is {name}{ext}?{hash} the source files shouldn't be fingerprinted.

Background information

Appending a query string without changing the file names is a popular cache busting technique.

Implementation

There are several ways to implement this:

1. If pattern {name}{ext}?{hash} then don't fingerprint source files (don't generate copy/don't allow replacement).
2. Provide a new option like -S, --Source -> Source file(s) without fingerprinting.
3. Provide a new option like -Q, --Query which sets the pattern to {name}{ext}?{hash} and doesn't fingerprint source files.