enanobots / m2-datapatchcreator Goto Github PK

View Code? Open in Web Editor NEW

49.0 49.0 13.0 64 KB

License: Open Software License 3.0

PHP 94.87% HTML 5.13%

m2-datapatchcreator's People

Contributors

Stargazers

Watchers

Forkers

julienanquetil siergiej-zarkiewicz markshust ihor-sviziev coresh proxiblue budnerp practice-code septoctobre qsolutions-pl lukaszqs pbrouwers

m2-datapatchcreator's Issues

Add changelog file

Pages/blocks sharing code in different scopes get merged

If you have a CMS page or block with differing content in different websites but sharing the same identifier code, and try to export both at once, they'll get merged improperly and only content for one will get written to the data patch.

Steps to reproduce:

Have two pages or blocks with the same code but different store scopes (like footer_links_col_5)
Select both footer_links_col_5 blocks on the admin grid, and export with the data patch creator

Expected behavior:

Two data patches in the download, one for each selected page

Actual behavior:

One data patch gets created, with the content from the higher entity ID.

I haven't investigated to determine if it creates both patches but one overwrites the other due to same filename (seems likely), or if they get grouped/merged by identifier prior to patch creation.

Secondary but related, since the existing record gets loaded by identifier without any scope filter, that will also cause incorrect behavior if multiple records exist with the same identifier, as in this case.

            $cmsBlock = $this->blockFactory->create();
            $this->blockResource->load($cmsBlock, 'footer_links_col_5', 'identifier');

Add some screenshots to readme file

It's not clear how the feature looks like. Would be great to add some screenshots or even gifs to show how it works

Compatibility with SimpleData module

Could we introduce another template to create data patches that work with Mark's SimpleData module?

That would be great!

Saving patches locally causes odd formatting in patch script

Files look fine when downloaded, but when saved directly to a folder, weird output happens:

<?php /**
 * Created with Nanobots_DataPatchCreatorSimpleData
 * @author      Jakub Winkler <[email protected]>
 *
 * @category    MarkShust
 * @package     MarkShust_MyData
 */

declare(strict_types = 1);

namespace MarkShust\MyData\Setup\Patch\Data;

use MarkShust\SimpleData\Setup\Patch\SimpleDataPatch;

class CmsPageHome extends SimpleDataPatch
{
    public function apply(): void
    {
        $this-&gt;page-&gt;save([
                'title' =&gt; 'Home page',
                'page_layout' =&gt; '1column',
                'meta_keywords' =&gt; '',
                'meta_description' =&gt; '',
                'identifier' =&gt; 'home',
                'content_heading' =&gt; 'Home Page',
                'content' =&gt; '<div data-content-type="html" data-appearance="default" data-element="main" data-decoded="true"><p>CMS homepage content goes here.</p>
            </div>',
                'creation_time' =&gt; '2021-10-29 15:45:29',
                'update_time' =&gt; '2021-10-29 16:58:06',
                'is_active' =&gt; '1',
                'sort_order' =&gt; '0',
                'layout_update_xml' =&gt; '<!--
                    <referenceContainer name="right">
                            <referenceBlock name="catalog.compare.sidebar" remove="true" />
                    </referenceContainer>-->',
                'custom_theme' =&gt; '',
                'custom_root_template' =&gt; '',
                'custom_layout_update_xml' =&gt; null,
                'layout_update_selected' =&gt; null,
                'custom_theme_from' =&gt; null,
                'custom_theme_to' =&gt; null,
                'meta_title' =&gt; '',
                'store_id' =&gt; [
                    0 =&gt; '0',
                ],
            ]);
    }
}

Specifically, the > arrows become >.

Issue:: "->" :: encoded

If i use page builder in the block or page i facing some issues after exporting the patch data. Some character are not decoded properly. I have attached the error file with this ticket. Please check and give your feedback.
OS: Ubuntu 18.04
Magento 2.4.3-p1 (vanilla instance)

<?php /**
 * Created with Nanobots_DataPatchCreator
 * @author      Jakub Winkler <[email protected]>
 * @author      Sebastian Strojwas <sebastian>
 * @author      Wojtek Wnuk <wojtek>
 *
 * @category    
 * @package     HomePageBanner
 */

namespace HomePageBanner\Setup\Patch\Data;

use Exception;
use Magento\Cms\Model\BlockFactory;
use Magento\Cms\Model\ResourceModel\Block as BlockResource;
use Magento\Framework\Setup\Patch\DataPatchInterface; 

class CmsBlockHomeBannerCategoryList implements DataPatchInterface
{
    /** @var BlockFactory */
    private $blockFactory;

    /** @var BlockResource */
    private $blockResource;

    /** 
     * @param BlockFactory $blockFactory
     * @param BlockResource $blockResource
     */
    public function __construct( 
        BlockFactory $blockFactory,
        BlockResource $blockResource
    ) { 
        $this-&gt;blockFactory = $blockFactory;
        $this-&gt;blockResource = $blockResource;
    }

    /**
     * @inheritDoc
     */
    public static function getDependencies(): array
    {
        return [];
    }

    /**
     * @inheritDoc
     */
    public function getAliases(): array
    {
        return [];
    }

    /**
     * @inheritDoc
     * @throws Exception
     */
    public function apply(): self
    {
        try {
            $cmsBlock = $this-&gt;blockFactory-&gt;create();
            $this-&gt;blockResource-&gt;load($cmsBlock, 'home-banner-category-list', 'identifier');
            $cmsBlock-&gt;addData([
                'title' =&gt; 'Home Banner Category List',
                'identifier' =&gt; 'home-banner-category-list',
                'content' =&gt; '<style>#html-body [data-pb-style=Y96V1N8]{justify-content:flex-start;display:flex;flex-direction:column;background-position:left top;background-size:cover;background-repeat:no-repeat;background-attachment:scroll}</style><div data-content-type="row" data-appearance="contained" data-element="main"><div data-enable-parallax="0" data-parallax-speed="0.5" data-background-images="{}" data-background-type="image" data-video-loop="true" data-video-play-only-visible="true" data-video-lazy-load="true" data-video-fallback-src="" data-element="inner" data-pb-style="Y96V1N8"><div data-content-type="html" data-appearance="default" data-element="main" data-decoded="true">{{widget type="SomethingDigital\\CategoryWidget\\Block\\Category\\CategoriesList" categories_count="10" template="SomethingDigital_CategoryWidget::category/widget/content/list.phtml" parent_category_id="2"}}</div></div></div>',
                'creation_time' =&gt; '2021-10-22 17:50:54',
                'update_time' =&gt; '2021-10-22 19:13:18',
                'is_active' =&gt; '1',
                'row_id' =&gt; '5',
                'created_in' =&gt; '1',
                'updated_in' =&gt; '2147483647',
                'store_id' =&gt; [
                    0 =&gt; '0',
                ],
                'stores' =&gt; [
                    0 =&gt; '0',
                ],
            ]);
            $this-&gt;blockResource-&gt;save($cmsBlock); 
            return $this;
        } catch (Exception $e) {
            throw new Exception(__('Cannot save CMS Block: %1', $e-&gt;getMessage()));
        }
    } 
}
</wojtek></sebastian>