emvakar / ekastrologycalc Goto Github PK

getMoonAges(date: Date) should returns moon age at a given date, why this function return an array of Int ?

getMoonModels(date: Date) should return EKMoonModel at a given date, why this function return an array of EKMoonModel ?

These two function should return 1 specific result from a given date, isn't it ? Or I miss something ?

Not working zodiac sign detection.
getMoonZodicaSign
Not sure why, but seems like Zodiac is detected wrongly by date passed like 20.07 should be cancer, but it is libra somewhy. But maybe it shouldn't work like that. Please, tell me if I misunderstood

Also, there is obvious mistake in this switch :

if (longitude < 33.18) {
            zodiac = .aries
        } else if (longitude < 51.16) {
            zodiac = .cancer
        } else if (longitude < 93.44) {
            zodiac = .gemini
        } else if (longitude < 119.48) {
            zodiac = .cancer
        } else if (longitude < 135.30) {
            zodiac = .leo
        } else if (longitude < 173.34) {
            zodiac = .virgo
        } else if (longitude < 224.17) {
            zodiac = .libra
        } else if (longitude < 242.57) {
            zodiac = .scorpio
        } else if (longitude < 271.26) {
            zodiac = .sagittarius
        } else if (longitude < 302.49) {
            zodiac = .capricorn
        } else if (longitude < 311.72) {
            zodiac = .aquarius
        } else if (longitude < 348.58) {
            zodiac = .pisces
        } else {
            zodiac = .aries
        }

it contains Cancer twice, but no Taurus
good luck with improving your library

I noticed that the Zodiac calculation precission is only by day (this function: getMoonZodicaSign(date: Date) ) Is it possible for you to update the code so that I can get the moon zodiac down to minutly precision?

print("Moon rise: -", $0.moonRise)
print("Moon set: -", $0.moonSet)

does not compile

Value of type 'EKMoonModel' has no member 'moonRise'
Value of type 'EKMoonModel' has no member 'moonSet'

How to get a moon illumination in Double (illuminated fraction of the moon; varies from 0.0 (new moon) to 1.0 (full moon) ) ?

I cannot run the code in the example. It gave me an error : Use of undeclared type 'MoonCalculatorManager'
at var moonPhaseManager: MoonCalculatorManager!

On Apple Watch i get this error that cause the crash of the app:
WatchKit App Extension[548:794557] Fatal error: Double value cannot be converted to Int because the result would be greater than Int.max: file Swift/armv7k-apple-watchos.swiftinterface, line 31242

The problem is for the var millisecondsSince1970 in the file Date+Extension.swift (line 29):

// Extended functionality to get milliseconds from 1970 to present time
public var millisecondsSince1970: Int {
    return Int((self.timeIntervalSince1970 * 1000.0).rounded())
}