emp-toolkit / emp-readme Goto Github PK

Two questions.

Maybe we should revise README

In the README, we mentioned:

Install related packages including cmake git build-essential libssl-dev libgmp-dev (for Linux), ..., or use this script.

Actually, boost is needed for Linux. But as the script shows, that needs a little bit efforts:

        sudo apt-get install -y software-properties-common
	sudo add-apt-repository -y ppa:george-edison55/cmake-3.x
	sudo add-apt-repository -y ppa:kojoley/boost
	sudo apt-get update
	sudo apt-get install -y cmake git build-essential libssl-dev libgmp-dev python 
	sudo apt-get install -y libboost1.58-dev
	sudo apt-get install -y libboost-{chrono,log,program-options,date-time,thread,system,filesystem,regex,test}1.58-dev

I think maybe we should tell the users to use the script instead? So Install related packages including cmake git build-essential libssl-dev libgmp-dev (for Linux) will be deleted.

Maybe we should change the script

Any reason for using libboost 1.58 and cmake for ppa? As if someone is using newer version of Ubuntu, maybe he/she already has newer versions.

And adding ppa is always not the best solution.

For Ubuntu 16.04, apt can find libboost 1.58 from ubuntu official source, and cmake 3.51.

Do you have a minimal Ubuntu version requirement in minds?

Install.py fails when -ag2pc is added. It fails with a complaint from cmake about missing add_test_with_lib macro.

This macro was present in earlier versions of emp_tool/cmake/common.cmake but was removed in df9446c

As a workaround, I copied the previous macro into emp-ag2pc/CMakeLists.txt and
cmake .
make
now complete.

Hi Xiao Wang,

I want to install emp-ot on my working pc (linux) which I don't have root access. How to avoid sudo make install at https://github.com/emp-toolkit/emp-readme/blob/master/scripts/install_emp-ot.sh#L5.

I try cmake . && make DESTDIR=.. all install for relic and emp-tool. However, when I compile emp-ot with cmake . CMAKE_SYSTEM_PREFIX_PATH=... I get a following error

1. CMAKE_FOLDER-NOTFOUND/cmake/common.cmake
2. CMAKE_FOLDER-NOTFOUND/cmake/source_of_randomness.cmake
3. CMAKE_FOLDER-NOTFOUND/cmake/threading.cmake
4. CMake Error at emp/emp-tool/cmake/emp-tool-config.cmake:2 (find_package)
5. Could not find a package configuration file provided by "relic"

I think it would be a simple option to set OPENSSL_ROOT_DIR to the default path in Mac.

However, shell script cannot change the global environment variables, but only sub-shells. It failed in Circle-CI. A related information is https://askubuntu.com/questions/53177/bash-script-to-set-environment-variables-not-working

a suggested way: Run! Let us assume w.l.o.g. the developer already sets OPENSSL_ROOT_DIR.