embroider-build / scenario-tester Goto Github PK

Context: we are using scenario-tester to test babel-plugin-ember-test-metadata against Classic & Embroider Ember build scenarios.

The problem we're seeing is that for Embroider build app scenarios, the file path prefix we get has a double tmp path.

Expected path: /private/var/folders/24/v9y37q75019cv62vg5ms10tw001llm/T/embroider/620a67/tests/acceptance/foo-test.js

Path we're getting in the Embroider scenario instead: /private/var/folders/24/v9y37q75019cv62vg5ms10tw001llm/T/embroider/620a67/private/var/folders/24/v9y37q75019cv62vg5ms10tw001llm/T/tmp-72329-6SsJEomJQDVe/tests/acceptance/foo-test.js

...and separate sources from generated artifacts.

1. We should definitely rename the Scenarios class as there is ambiguity between it and a plural of the Scenario class.
2. There is a lot of diffusion of meaning between the terms Scenario, scenario, variant, derived project, etc. We should make effort to separate those and meaningfully explain in documentation.
3. Review code to identify more opportunities for clarification.

This came up in this PR: embroider-build/embroider#1126 (review)

Where I'm trying to build a library that is linked to an app.

The issue is that I can't seem to run rollup in the linked addon and have those assets available to the PreparedApp.

execute, exists on the app, but is not available for linked packages.

@ef4 suggested this API:

await app.inDependendency('v2-addon').execute('yarn rollup -c ./rollup.config.mjs')

which seems reasonable 🤷

saw https://github.com/ef4/scenario-tester/blob/main/index.ts#L169
and that's a mutable field.
But given the usage and the fact that a Project errors if you change baseDir after it's created, I think it makes sense to have PreparedApp#dir also be read only?

The Scenarios class is documented and pending review: #16

We need to document remaining classes. The amount of work left is small compared to what's already been done.