Enhance contextual-components & helpers about rfcs HOT 4 CLOSED

From the previous requirements I conclude that if we want to handle components and helpers with the same syntax, we need two keywords.

The name is not very important at this point, but let's pretend the keywords are invoke-component and wrap-component.

We know that it has to support glimmer components. The syntax of glimmer components is, according to the last rumours, going to have @foo= values for properties and foo= for attributes, so those helpers should respect that syntax.

Aternative 1: curly-braces syntax for components and helpers

The idea is that the helpers receive the first argument, determine if it's a component or a helper and pass the arguments as received, which means that
arguments with an @ sign become properties in the component instance and those without @ become properties.

Invocation:

{{#invoke-component "my-button" class="btn btn-success" @loadingMessage="Wait please ..."}}
  Submit!
{{/invoke-component}}
{{!-- equivalent to <my-button class="btn btn-success" @loadingMessage="Wait please ...">Submit!</my-button> --}}

{{invoke-component "moment-format" today "YYYY-MM-DD" locale="fr"}}
{{!-- equivalent to {{moment-format today "YYYY-MM-DD" locale="fr"}} --}}

{{invoke-component "my-component" title=(invoke-component "moment-format" date)}}
{{!-- equivalent to <my-component class={{moment-format date}}>Submit!</my-component> --}}

Contextual components/helpers creation:

<my-form class="my-form" @submitBtn={{wrap-component "x-button" class="btn btn-success" @loadingMsg="Please wait..."}}></my-form>

{{!-- Later on, inside the my-form.hbs template --}}
{{invoke-component submitBtn @anotherAttr="foo" aria-hidden="true"}}

<my-calendar @format-date={{wrap-component "moment-format" locale="fr" format="YYYY-MM-DD"}}></my-calendar>
{{!-- Later on, inside the my-calendar.hbs template --}}
Today is {{invoke-component format-date today}} and tomorrow is {{invoke-component format-date tomorrow}}

Shorthand invocation of contextual glimmer-components:

{{!-- my-form.hbs --}}
{{yield hash=(
  format-created-at=(wrap-component "moment-format" model.createdAt)
  cancel-btn=(wrap-component "form-button" class="btn-warning" @onClick=(action "cancel"))
  submit-btn=(wrap-component "form-button" class="btn-sucess" @onClick=(action "submit"))
)}}

<my-form @model={{model}} as |f|>
  <p>This moment was created at {{f.format-created-at "YYYY-MM-DD"}}</p> {{!-- Invoke a helper --}}
  <f::cancel-button>Abort</f::cancel-button>
  <f::submit-button>Save</f::submit-button>
</my-form>

from rfcs.

I am all in favor of adding this feature since it would allow to create better public APIs for components like the ones in the ember-power family.

One option to avoid the wrap Vs. invoke helpers might be to restrict it to the dot syntax: if a property path resolves to either a component or a helper, it would be just rendered as such.

I would need to know more about current implementation of contextual components, since last time I checked (July? August?) it was partially coded as an special case. Maybe @zackthehuman can help a bit here.

I'm all in for investigating this further. Great work, @mixonic!

from rfcs.

@Serabe What do you mean to restrict it to the dot syntax? With components is easy, but components are eager, so {{my-foo format-today=(helper "moment-format" today)}} is ambiguous in the sense that you don't know if you want to wrap the helper to later on invoke it with {{format-today}} or you want to call it inmmedialtly and use the generated value in JS-land.

from rfcs.

This was replaced by #432 which is merged, and awaiting implementation. Closing this issue in favor of tracking the progress of that RFC.

from rfcs.