Git Product home page Git Product logo

Comments (9)

rwjblue avatar rwjblue commented on June 6, 2024 2

RE: script names, I personally like lint:prettier and lint:prettier:fix for the two scripts. It plays well with the other top level scripts that we use lint and lint:fix.

from rfcs.

rwjblue avatar rwjblue commented on June 6, 2024 1

It should also use --ignore-unknown IMO. This is what I tend to use:

    "lint:prettier": "prettier --cache --ignore-unknown --check .",
    "lint:prettier:fix": "prettier --cache --write --ignore-unknown ."

from rfcs.

NullVoxPopuli avatar NullVoxPopuli commented on June 6, 2024

I'm a fan. It turns out that the prettier integratios for eslint is really slow.
Also, some folks manually deal with red squigglies in their editor (even despite knowing about the format document command, or running eslint on save), so removing those would be a productivity boost for them.

from rfcs.

kellyselden avatar kellyselden commented on June 6, 2024

Wouldn't it be something like "format" and "format:fix" to match the other conventions?

from rfcs.

NullVoxPopuli avatar NullVoxPopuli commented on June 6, 2024

why learn extra CLI commands?

we have lint:glint, too -- which is quite nice (bundled in to lint)

from rfcs.

kellyselden avatar kellyselden commented on June 6, 2024

why learn extra CLI commands?

What are you referring to? I'm referring to out existing conventions of using ":fix" to do code changes https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/package.json#L18.

from rfcs.

bertdeblock avatar bertdeblock commented on June 6, 2024

The script names are probably not ideal at the moment, other suggestions are certainly welcome!
I mainly wanted the Prettier check to automatically be picked up when running npm run lint, hence lint:format.
And now that I think about it, it should probably be lint:format:fix, for it to be picked up by lint:fix.

from rfcs.

wagenet avatar wagenet commented on June 6, 2024

I do something very similar in the apps I work on, so I'm completely on board with this.

from rfcs.

bertdeblock avatar bertdeblock commented on June 6, 2024

Updated the format script to lint:format:fix in my initial comment.
Though, I have no strong preference between lint:format:* and lint:prettier:*.
I like that lint:format:* is more agnostic of the used tool, but lint:prettier:* is probably more clear.

from rfcs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.