Comments (9)
RE: script names, I personally like lint:prettier
and lint:prettier:fix
for the two scripts. It plays well with the other top level scripts that we use lint
and lint:fix
.
from rfcs.
It should also use --ignore-unknown
IMO. This is what I tend to use:
"lint:prettier": "prettier --cache --ignore-unknown --check .",
"lint:prettier:fix": "prettier --cache --write --ignore-unknown ."
from rfcs.
I'm a fan. It turns out that the prettier integratios for eslint is really slow.
Also, some folks manually deal with red squigglies in their editor (even despite knowing about the format document command, or running eslint on save), so removing those would be a productivity boost for them.
from rfcs.
Wouldn't it be something like "format" and "format:fix" to match the other conventions?
from rfcs.
why learn extra CLI commands?
we have lint:glint
, too -- which is quite nice (bundled in to lint)
from rfcs.
why learn extra CLI commands?
What are you referring to? I'm referring to out existing conventions of using ":fix" to do code changes https://github.com/ember-cli/ember-cli/blob/master/blueprints/app/files/package.json#L18.
from rfcs.
The script names are probably not ideal at the moment, other suggestions are certainly welcome!
I mainly wanted the Prettier check to automatically be picked up when running npm run lint
, hence lint:format
.
And now that I think about it, it should probably be lint:format:fix
, for it to be picked up by lint:fix
.
from rfcs.
I do something very similar in the apps I work on, so I'm completely on board with this.
from rfcs.
Updated the format
script to lint:format:fix
in my initial comment.
Though, I have no strong preference between lint:format:*
and lint:prettier:*
.
I like that lint:format:*
is more agnostic of the used tool, but lint:prettier:*
is probably more clear.
from rfcs.
Related Issues (20)
- Replace `babel-eslint` with `@babel/eslint-parser` in blueprints HOT 3
- Switch default package manager to pnpm for new projects + C.I. HOT 44
- Public API support disparity with Glint and typed templates with custom managers -- currently no story for TS support (for now?) HOT 5
- Deprecate support for `ember-cli-qunit` and `ember-cli-mocha` when generating test blueprints HOT 3
- Standardize the use of yarn and npm scripts in the Ember experience, for test and start HOT 11
- V2 addons' build-time integration HOT 4
- Deprecate all of Ember Classic HOT 16
- Build-time configuration of index.html HOT 3
- Deprecate support for Travis CI HOT 6
- Deprecate `ember-mocha`? HOT 2
- Deprecate `ember-export-application-global` addon? HOT 4
- Deprecate `app.import`
- Thoughts on this more ergonomic way to wire up the owner + destroyable association? HOT 2
- Explore "official" pod deprecation HOT 19
- {{else}} should render a value rather than be a control-flow keyword. HOT 5
- new primitive: transition, similar to modifiers, except they block certain render events HOT 2
- Numbers in PR titles affect automation
- Asset import spec RFC HOT 2
- Implement import spec RFC HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rfcs.