ember-polyfills / ember-in-element-polyfill Goto Github PK

[email protected] seems to cause deprecation warnings under ember 3.28.x.

Deprecation id: template-compiler.registerPlugin
https://deprecations.emberjs.com/v3.x/#toc_template-compiler-registerPlugin

"ember-source": "^3.28.8"
"ember-cli": "^3.28.4"

This polyfill is not conforming to the final public API from the RFC, specifically this section:

There is however one part of the behavior that the core team wants to make explicit before promoting the private API to public, and that is how the content is added to the destination when there is other content already there.

The desired behavior is that, by default, the rendered content will replace all the content of the destination, effectively becoming the its innerHTML. In the current behaviour the rendered content is appended as the end of any existing content. This will still be supported by passing insertBefore=null, but it will not be the default anymore. Any other value passed to insertBefore must produce an error.

Using Ember v3.3.0 when attempting to use in-element I get the error message:
The {{in-element}} helper cannot be used

I've made an ember-polyfills org and moved all of the polyfills I've written into it. The idea is roughly to increase bus factor while also increasing discoverability.

What do you think about moving this repo into that org? I'll happily add you as an owner there...

Thanks for your assistance the other day - I've managed to get in-element working now - so that was much appreciated.

I'm using the polyfil on on a change I'm making to the ember-cli-photoswipe addon.

One issue I've encountered is that while the polyfill works fine in the dummy application provided with the addon; when I try to use the updated version of photoswipe in a real application the polyfill is installed but is not found. I get the error message:
Error: Assertion Failed: A component or helper named "in-element" could not be found.

If I manually install the polyfill on the real world application then photoswipe works.
I don't understand why this is as I have the polyfill in the dependencies section of the package.json.
https://github.com/MrChriZ/ember-cli-photoswipe/tree/useInElement

Am I missing something obvious?

It looks like you are transforming all in-element to -in-element what about ember versions that has the native in-element ?
I get the following error when starting my app:

I'm using Ember 3.20 and ember-leaflet:4.1.1 which use your library internally

Howdy folks?

Any chance we can get a 1.0 version of this? It seems to be used by loads of people but I think it would be better to get it into "proper semver" if at all possible 🤔

Any thoughts?