ember-engines / engine-blueprint Goto Github PK

License: MIT License

JavaScript 99.86% Handlebars 0.14%

engine-blueprint's Introduction

ember-engines

This Ember addon implements the functionality described in the Ember Engines RFC. Engines allow multiple logical applications to be composed together into a single application from the user's perspective.

Packages

This project is a monorepo managed by pnpm workspaces. All packages are organized in the /packages/ directory.

The only public package is ember-engines. Other packages are private to this repo and are used to support testing ember-engines.

Documentation

Check the full documentation in the Ember Engines Guides.

Support

Having trouble? Join #ember-engines on the Ember Community Discord server

Contributing

See the Contributing guide for details.

License

engine-blueprint's People

Contributors

Stargazers

Watchers

Forkers

status200 kellyselden jbailey4 gcheung55 rajasegar villander richgt

engine-blueprint's Issues

Add Yarn support?

While trying to create new engine with this blueprint, I came across the error:

Error creating new application. Removing generated directory ./example-engine
Cannot find module '/Users/gcheung/.nvm/versions/node/v8.14.1/lib/node_modules/ember-cli/blueprints/addon/index'

I have ember-cli installed globally using Yarn, which is why the ember-cli/blueprints/addon/index isn't found.

Evaluate moving to `PatchableFileInfo`

@stefanpenner wrote a PatchableFileInfo class for the ember-next blueprint, which seems to simplify some of the things we are doing. We should consider extracting that into a stand alone library and using it here...

See https://github.com/ember-cli/ember-next/blob/master/index.js#L41.

Publish to NPM

Are there any updates on when this will be published to the NPM registry?

cc/ @rwjblue @trentmwillis

Update ember-engines version in blueprint

ember-engines blueprint version is outdated

    // Add `ember-engines` to devDependencies by default
    contents.devDependencies['ember-engines'] = '^0.5.14';

only works with ember-cli < 2.15.0

There is an explicit call to Addon.generatePackageJson here in /index.js. Seems like this method was renamed to updatePackgeJson in ember-cli here, and released in [email protected].

Downgrading to a version of ember-cli <2.15.0 works with this blueprint.

Perhaps this could be mentioned in the README for now until this blueprint is updated.

`ember g route <route-name> --in-repo <engine>` not adding the right route on routes.js

Ember CLI: 3.16.0
Ember: 3.16.0
Ember Data: 3.16.0
Ember-engines: 0.8.5

While running this command to generate a route inside the in-repo engine, the routes and the respective files are generated, but the entry inside routes.js of the in-repo engine isn't updated.

Not sure if this is the right repo for tracking this issue, but feel free to close if not.