Git Product home page Git Product logo

Comments (7)

pzuraq avatar pzuraq commented on June 4, 2024 2

In the pods/MU style, the information is one level up, the folder name that contains the file:

/MLDP.WebApp/mldp/account/action/controller.js:

Should output:

export default ActionController extends Controller {}

I think folks may want this to be even less generic, like AccountActionController, but I don't think that's something we can automate, so probably just the single enclosing folder is the best thing to add to the class name.

from ember-native-class-codemod.

pzuraq avatar pzuraq commented on June 4, 2024

Ah, I don't think we handled pod/MU style declarations of names, @ssutar we definitely should add this functionality (also PRs definitely welcome! 😄)

from ember-native-class-codemod.

knownasilya avatar knownasilya commented on June 4, 2024

I'd contribute if I even understood how this thing worked. Where is the code? Haha!

from ember-native-class-codemod.

knownasilya avatar knownasilya commented on June 4, 2024

Looks like the code is here: https://github.com/scalvert/ember-es6-class-codemod/blob/master/transforms/helpers/parse-helper.js#L477

Do we have pods code anywhere? Will the testing layout need changes like mimicking pods?

from ember-native-class-codemod.

pzuraq avatar pzuraq commented on June 4, 2024

I don’t believe any pods code exists yet, and we definitely will need new tests/fixtures that mimic the pods structure. I think the new tests should be pretty straightforward, basically an input directory and output directory, though I’m not sure if our tests handle directories yet

from ember-native-class-codemod.

ssutar avatar ssutar commented on June 4, 2024

@pzuraq Isn't this same as #49 where we would append the class type. So this would become

export default class ControllerController extends Controller

which is not a good name but is valid

from ember-native-class-codemod.

pzuraq avatar pzuraq commented on June 4, 2024

This should be fixed on master, let us know if you're still having issues!

from ember-native-class-codemod.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.