Comments (7)
In the pods/MU style, the information is one level up, the folder name that contains the file:
/MLDP.WebApp/mldp/account/action/controller.js:
Should output:
export default ActionController extends Controller {}
I think folks may want this to be even less generic, like AccountActionController
, but I don't think that's something we can automate, so probably just the single enclosing folder is the best thing to add to the class name.
from ember-native-class-codemod.
Ah, I don't think we handled pod/MU style declarations of names, @ssutar we definitely should add this functionality (also PRs definitely welcome!
from ember-native-class-codemod.
I'd contribute if I even understood how this thing worked. Where is the code? Haha!
from ember-native-class-codemod.
Looks like the code is here: https://github.com/scalvert/ember-es6-class-codemod/blob/master/transforms/helpers/parse-helper.js#L477
Do we have pods code anywhere? Will the testing layout need changes like mimicking pods?
from ember-native-class-codemod.
I don’t believe any pods code exists yet, and we definitely will need new tests/fixtures that mimic the pods structure. I think the new tests should be pretty straightforward, basically an input directory and output directory, though I’m not sure if our tests handle directories yet
from ember-native-class-codemod.
@pzuraq Isn't this same as #49 where we would append the class type. So this would become
export default class ControllerController extends Controller
which is not a good name but is valid
from ember-native-class-codemod.
This should be fixed on master, let us know if you're still having issues!
from ember-native-class-codemod.
Related Issues (20)
- Error `Cannot read property 'from' of undefined` HOT 1
- Attempted to access the computed <Obj>.computedPropName on a destroyed object errors in acceptance tests after running this codemod HOT 2
- Incorrect transform this._super(...arguments) to undefined
- TypeError: Cannot read property 'entries' of undefined HOT 10
- TypeError: Cannot read property 'from' of undefined HOT 7
- Does not match field "body"
- Error `Error: Evaluation failed: TypeError: Cannot convert undefined or null to object` HOT 1
- TypeError: Cannot read property 'process' of undefined HOT 4
- `queryParams` needs to be an array
- Error when encountering ArrowFunctionExpression in computed setter HOT 2
- Codemod mistakes `computed.equal` for a modifier HOT 2
- Convert classic fields to prototype fields instead of class fields when run against an addon HOT 2
- ReferenceError: regeneratorRuntime is not defined if using babel.config.json
- Puppeteer version is not compatible with M1 Macs HOT 1
- I am getting `Ember is not defined` errors in a lot of the files
- Produces class decorator usage with incorrect syntax HOT 1
- codemod is removing async from methods HOT 1
- Codemod still mis-handling boolean CLI args as strings HOT 1
- Error count doesn’t match log.
- Unmodified when running codemod HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-native-class-codemod.