It's not clear where configs go in relation to ENV. Can anyone provide 1 example?

The default filePattern for files to be included in the manifest is:

"**/*.{js,css,png,gif,ico,jpg,map,xml,txt,svg,swf,eot,ttf,woff,woff2}"

If I understood correctly, plugins that respect the manifest (such as ember-cli-deploy-s3) will only ever upload files that they find listed in the manifest (if they have different fingerprints that is).

Doesn't that imply that all files not matching the pattern will be completely ignored?

Take what-is-love.webm for example. If (for whatever reason) someone needed to statically embed this webm video in their website, the video would never be uploaded, because it doesn't match the default file pattern. I did not actually test this though, but if I understood the docs correctly, precisely this would happen.

I can understand why a file filtering feature could be useful and don't advocate to remove it as a whole, but I'd set the default pattern to "**/*" so all files are matched.
Or even better yet, set filePattern: false and implement a simple switch that skips the filtering for performance reasons if the filePattern is false-y.
Alternatively we could test for "**/*" and just skip in that case to keep the human interface more intuitive.

If I did not miss any deeper reason for this and the change would be welcome, I'd make a quick PR. 😀

Merry X-MAS everybody! 🎄

I have a /service-worker.js file I can't fingerprint and should always be uploaded.
I tried to do this but didn't work:

ENV.manifest.filePattern = '**/!(service-worker.js).{json,js,css,png,gif,ico,jpg,xml,txt,svg,swf,eot,ttf,woff,woff2,htm}';

It won't be added to the deploy manifest and won't be uploaded.

Anyway I can make this work?

Hey, it could be me not fully understanding how ember-cli-deploy works, but the manifest plugin trolled me for a bit when I tried to deploy to a "development" target (because the file names didn't change, and in result no new files were uploaded).

I think it'd be nice to at least warn about this in the readme (and possibly in the console when doing the build?), or disable this plugin for development builds by default. What do you think?

My use case is I need to deploy certain files to s3 on every deploy. The files in question are not fingerprinted, but should always be deployed. I can achieve this by not having the file present in the manifest. Adding ignoreFilePattern would allow me to configure my deploy.js to ignore my always needed to deploy files.

Previously opened an issue to solve a different way in ember-cli-deploy-s3 --
ember-cli-deploy/ember-cli-deploy-s3#92

@achambers suggested this fix instead.

https://github.com/ember-cli-deploy/ember-cli-deploy-manifest/blob/master/package.json#L52

I have some deployment targets like dev and staging that don't compress the assets with a new hash in the name. So when using this plugin, my assets are not deployed because their file names aren't changing. What's the best way to turn this off for targets like these?