Git Product home page Git Product logo

vintagefix's Introduction

vintagefix's People

Contributors

embeddedt avatar supermartijn642 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

vintagefix's Issues

Problems with Resource Loader

After adding items and blocks using Content Tweaker, they do not display textures that are loaded using Resource Loader
image

Stygian end continuation have liquid missing texture

this issue occur when mixin.dynamic_resources=true

Screenshot :
mixin.dynamic_resources=false
Capture d’écran_2023-06-25_05-28-37

mixin.dynamic_resources=true
Capture d’écran_2023-06-25_05-30-38

location : 10000 100 20000
seed : -3394210783161434791
dimension : nether

mods list :

!mixinbooter-7.1
vintagefix-0.2.2
stygian-1.0.5

Texture oddity with Project Red gates

Using release version VintageFix 0.1.0, first 3 mods are reproducible with minimal mods

  • Binnie's Mods: All fluids from this mod in HEI recipes are invisible, in-world is fine
  • DivineRPG: Nightmare bed item texture is invisible, in-world is fine
  • Integrated Dynamics: Programmed variables and other icons are still broken as in #23
  • Project Red Integration: The "cathode" parts of gates have a weird texture when they are ON; not sure how to reproduce with isolated mod list, but can reproduce in Meatballcraft and by adding all the ProjectRed mods to E2EU.
    2023-06-15_11 52 37
    2023-06-15_11 53 27
    2023-06-15_11 54 43
    2023-06-15_13 55 06

Dynamic Resources optimization causes slowdown in JEI/HEI, especially noticeable with vanilla and custom resources

When viewing items in HEI such as scrolling through pages, there is a very noticeable slowdown/freezing clientside as HEI waits for some textures to load. This slowdown is especially evident if there are custom resources in a /resources folder, such as through ResourceLoader, ContentTweaker/BASE, and Roost. I know it should be expected that dynamic resources will affect performance as the game must load resources that were skipped in the loading stages, but the performance impact on HEI seems to be quite high when using custom resources.

Another scenario where this slowdown is noticeable is when you first load the vanilla textures in HEI (around the first 3 pages on large GUI scale) or otherwise have to reload those vanilla textures because (I assume) they are no longer in the cache. This is arguably the more important issue because this means when clearing your search or otherwise showing the first page of vanilla items, if vanilla textures need to reload, the search will be laggy. Spark profile for that here.

Some blocks/items I noticed considerably struggle to load in HEI are ones from the mods Advent of Ascension, DivineRPG, Betweenlands, Ice and Fire, and of course the aforementioned ContentTweaker.

The following Spark profiles give more info on what is causing these slowdowns (profiled while just scrolling through HEI):

  • Profile with ResourceLoader enabled
  • Profile with ContentTweaker resources

The slowdown seems to depend on the number of resources in the folder, as when I have ContentTweaker/BASE enabled but deleted the entire /resources folder, HEI's performance improved compared to having many resources in the folder. I have highlighted what seem to be the biggest offenders in each profile, which seems to be due to calls to java.io.File.getCanonicalPath() or more specifically java.io.WinNTFileSystem.canonicalize(). I am using Windows, so I'm not sure if the performance impact would be different on Linux.

I tested on the modpack Meatballcraft (which is where all the Spark reports are from), which uses ResourceLoader, ContentTweaker, and Roost resources. I also tested briefly on E2EU, which seems to only noticeably lag in the scenario of (re)loading vanilla textures.
*Using VintageFix as of commit d4a3a56

Multiple visual issues with other mods

All are visual issues only
Gameplay is normal, no real impact.

  • (Thaumcraft) Item(s?) missing texture (ex: Caster Gauntlet) - Related to #4
  • (Mekanism) Pipe disappeared.
  • (AE2) Blocks face wrong direction (north | ex: ME Drive, Interface)
  • (Immersive Petroleum) Multiblock(s?) missing texture (Distillation Tower)
  • (Advanced Rocketry) Block(s?) missing model (Monopropellant Fuel Tank)
  • Multiblocks render dark than normal - Related to #5

What does 100+ errors means? `DynamicModelProvider: Failed to load model`

After installing VintageFix, i got hundreds of new errors in debug.log file.

What do all these errors mean?
Does it mean that some of the VintageFix functionality does not work?
Is there any way I can configure VintageFix to fix these errors myself?

  1. 💥77 errors DynamicModelProvider: Failed to load model
[Client thread/ERROR] [org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider]: Failed to load model thaumicaugmentation:ward_foci_no_coremod
net.minecraftforge.client.model.ModelLoaderRegistry$LoaderException: Exception loading model thaumicaugmentation:ward_foci_no_coremod with loader VanillaLoader.INSTANCE
	at org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider.loadModel(DynamicModelProvider.java:179) ~[DynamicModelProvider.class:?]
[...]
Caused by: org.embeddedt.vintagefix.util.FastFileNotFoundException: thaumicaugmentation:models/ward_foci_no_coremod.json
  1. 💥4 errors Early load error for ...
[Client thread/ERROR] [VintageFix]: Early load error for thaumicaugmentation:ward_foci_no_coremod
java.lang.RuntimeException: net.minecraftforge.client.model.ModelLoaderRegistry$LoaderException: Model loading failure
[...]
Caused by: net.minecraftforge.client.model.ModelLoaderRegistry$LoaderException: Model loading failure
	at org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider.loadModelFromBlockstateOrInventory(DynamicModelProvider.java:119) ~[DynamicModelProvider.class:?]
	at org.embeddedt.vintagefix.dynamicresources.model.DynamicModelProvider.lambda$getObject$0(DynamicModelProvider.java:61) ~[DynamicModelProvider.class:?]
  1. 💥31 errors DynamicBakedModelProvider: Error occured while loading model
[Client thread/ERROR] [org.embeddedt.vintagefix.dynamicresources.model.DynamicBakedModelProvider]: Error occured while loading model enderio:block_painted_double_slab#inventory
  1. 💥1 error FastFileNotFoundException
[pool-12-thread-1/ERROR] [base]: org.embeddedt.vintagefix.util.FastFileNotFoundException: biomesoplenty:textures/items/gem.png
  1. 💥6 errors Suppressing further model loading errors for namespace
[VintageFix item baking thread/ERROR] [VintageFix]: Suppressing further model loading errors for namespace 'betteranimalsplus'
  1. 💥1862 lines of FML.TEXTURE_ERRORS
    Its not actually VintageFix error, but was started to be printed after i installed VintageFix
==================================================
  DOMAIN farm/animania
--------------------------------------------------
  domain farm/animania is missing 132 textures
    domain farm/animania is missing a resource manager - it is probably a side-effect of automatic texture processing
-------------------------
    The missing resources for domain farm/animania are:
      textures/items/cooked_hereford_steak.png
      textures/items/bottle_milk.png
      textures/items/bee_hive.png
[...]
  1. 18 warnings Cannot list resources from pack
Cannot list resources from pack HammerCore Connected Models (com.zeitheron.hammercore.api.inconnect.EmptyModelPack)
Cannot list resources from pack resources (com.teamacronymcoders.base.util.files.DirectoryResourcePack)
Cannot list resources from pack CustomResources (lumien.resourceloader.loader.NormalResourceLoader)
Cannot list resources from pack quark-texture-proxy (vazkii.quark.base.client.ResourceProxy)
Cannot list resources from pack aquaacrobatics-new-water (com.fuzs.aquaacrobatics.client.model.WaterResourcePack)
  1. 4 warnings Path ... is not a valid model location
[Client thread/WARN] [VintageFix]: Path mixins.sledgehammer.conarm.json is not a valid model location
  1. 33 warnings Can't preload sprite class
Can't preload sprite class com.rwtema.extrautils2.modcompat.TinkersIntegration$2$1 (seen 151/50732 times)
Can't preload sprite class net.minecraftforge.client.model.ModelLoader$White (seen 1/50732 times)
Can't preload sprite class twilightforest.client.texture.GradientMappedTexture (seen 41/50732 times)
Can't preload sprite class slimeknights.tconstruct.library.client.texture.GuiOutlineTexture (seen 40/50732 times)
Can't preload sprite class net.minecraftforge.client.model.ModelDynBucket$BucketCoverSprite (seen 1/50732 times)
Can't preload sprite class net.minecraftforge.client.model.ModelDynBucket$BucketBaseSprite (seen 1/50732 times)
  1. 2 warnings Texture ... was not discovered during texture pass
[VintageFix item baking thread/WARN] [org.embeddedt.vintagefix.dynamicresources.model.DynamicBakedModelProvider]: Texture neenergistics:blocks/pattern_interface was not discovered during texture pass
[pool-12-thread-1/WARN] [org.embeddedt.vintagefix.dynamicresources.model.DynamicBakedModelProvider]: Texture neenergistics:blocks/pattern_interface was not discovered during texture pass

debug.log

Issues with Refined Storage and OpenComputers

  • Refined Storage cable covers appear invisible
    2023-06-22_12 07 25

  • RS patterns do not display as the resulting item (below should appear as crafting table)
    2023-06-22_11 56 01

  • OpenComputers screens have incorrect textures (should appear connected and have unique textures for each tier.
    2023-06-22_12 07 41

  • Mod list
    Screenshot 2023-06-22 122252

Log spam

1.Selected some spam messages, there are hundreds of them
https://mclo.gs/2ZkwDOn
https://mclo.gs/oraTTHW

2.Tinkers' problem,like this

[16:27:46] [pool-16-thread-1/ERROR] [tconstruct-API]: Could not load material model conarm:parts/armor_trim.tmat#inventory
[16:27:46] [pool-16-thread-1/ERROR] [tconstruct-API]: Could not load material model conarm:parts/armor_plate.tmat#inventory
[16:27:46] [pool-16-thread-1/ERROR] [tconstruct-API]: Could not load material model conarm:parts/chest_core.tmat#inventory
[16:27:46] [pool-16-thread-1/ERROR] [tconstruct-API]: Could not load material model conarm:parts/leggings_core.tmat#inventory
[16:27:46] [pool-16-thread-1/ERROR] [tconstruct-API]: Could not load material model conarm:parts/boots_core.tmat#inventory
[16:27:46] [pool-16-thread-1/ERROR] [tconstruct-API]: Could not load material model conarm:parts/polishing_kit.tmat#inventory

Crashing/Compatibility Issues with VintageFix and unknown mod(s)?

Hi and sorry to disturb you. I know this mod is heavily a work in progress. Not to mention new and you're still ironing out the kinks.

This mod has compatibility issues with Binnie's Mods, at least Acgaming's fork.
https://github.com/ACGaming/Binnie

It implements a couple of new things and fixes bugs. Such as crashing with certain trees. But it really doesn't like loading certain models.

Another issue is Between lands with model loading. I know it doesn't like the buckets last I checked as well as certain loading with lantern models. I saw recently a crash was fixed, but am uncertain to what other degree stuff was fixed.


I'm using the latest version compiled to this comment. It's now started crashing and listing stuff as invalid sound wise. Even without various mods that include noises.

Here's my crash log and log.
crash-2023-05-27_22.03.40-client.txt

latest.log


Again sorry. Perhaps my last question would be is if your old project MUP will be incorporated into this? Or if you're trying to get maximum compatibility with things like Universal Tweaks and other mods. I know that there's a ton of optimization and fixes. As well as suggestions and things to incorporate.

Thank you for all your hard work on the various mc versions. As well as for doing this for the community and people like me. It means alot to me. Even if work on this version of mc isn't as popular as 1.16+. At least not anymore lol.

Add comments to the config file (pretty please)

As a modpack dev and not a modder, I don't understand most or any of what the options in the cfg file are or what they do.

Would also be useful for cases such as this (#39) where a comment could say "enabling may increasing TPS during world gen"

and #25 could say "disable if using Better Foliage"

(also, please add a changelog to the curseforge updates! it would be greatly appreciated!)

thank you for your hard work! ❤️

[bug]background bug

The CMM Mod cannot display properly and shows a black screen for a few seconds.

java.2023-07-14.09-52-09-611.mp4

Seems to be crashing with Agricraft

I was messing with some mods within DJ2, using the last nightly build available at this moment. Looks like the problem narrows down to Vintagefix.

net.minecraftforge.fml.common.LoaderExceptionModCrash: Caught exception from AgriCraft (agricraft)
Caused by: java.lang.NoClassDefFoundError: com/agricraft/agricore/util/ResourceHelper
at com.infinityraider.agricraft.core.CoreHandler.preInit(CoreHandler.java:68)

When vintagefix is enabled i got higher tps overhead during worldgen

When vintagefix is enabled i got higher tps overhead during worldgen

this issue can be fixed by disabling mixin.bugfix.missing_edge_chunks

mods lists :

  • !mixinbooter-7.1
  • Patcher-1.12.2-1.8.7a
  • vintagefix-0.2.7
  • !configanytime-1.0
  • UniversalTweaks-MB7-1.12.2-1.7.0

note :

I used Universaltweaks to use chunkgenlimiter to watch accurate tps usage with patcher mod

videos :

Vintagefix enabled

https://mega.nz/file/HpUEhJzB#TaN04-6Kmpyz2A3nVAEJ5vw8Z-mY8uKJlPnIifnPsyo

Vintagefix disabled

https://mega.nz/file/moFCzYTY#H5cznLNSoNgnZNXfPY7IhJwlBISWW7JiP8MyvDRHBMA

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.