Comments (8)
Thanks for taking the time to bisect the regression! I'll take a look at it
when I'm done my exam ;)
Side note, we should probably start building up a test suite to catch
regressions like these.
On May 16, 2012 8:17 AM, "Sylvain Rousseau" <
[email protected]>
wrote:
I updated helm to last commit and i found a regression. Helm is no longer
able to visit files from Locate or Recentf section in helm-for-files. I
bisected and the culprit seems to be de6cb44!
Reply to this email directly or view it on GitHub:
#59
from helm.
I'm happy it is known issue and not something weird with my emacs setup!
from helm.
@haxney Test suite is always a good idea. ERT is part of Emacs 24 and there is also ecukes
from helm.
@bbatsov That's what I'm thinking. It'd be a big boon to Emacs if there was a (relatively) comprehensive test suite.
Back on topic: @dixie I haven't yet checked whether I have that same regression. O time, how fleeting thou art! Did you check to see if it happens in emacs -Q
? Also, what's your OS, Emacs version, etc?
from helm.
@dixie Can't reproduce this bug here, all is working fine.
Please try from 'emacs -Q' as suggested by @haxney.
Also what mean "helm is not able to visit files"?
Describe exactly what you are doing from emacs -Q, turn on debug-on-error and send us the resulting backtrace if some.
Thanks.
from helm.
This was already tested with emacs -Q. At commit de6cb44^ the full path in helm-for-files is still visible, helm is visiting the file without any problem. At commit de6cb44 only the file names are visible, the basename part has been removed.
The problem is that when choosing an entry helm is trying to visit only the filename. helm is opening an empty buffer in `default-directory' that has the same name of the selected entry.
Too weird that i'm the only one having this problem!
Using GNU Emacs 24.0.96.1 on LMDE
Edit: problem is helm-c-highlight-files that has been moved from helm-c-source-files-in-current-dir to helm file attribute
from helm.
Sylvain Rousseau
[email protected]
writes:
This was already tested with emacs -Q. At commit de6cb44^ the full
path in helm-for-files is still visible, helm is visiting the file
without any problem. At commit de6cb44 only the file names are
visible, the basename part has been removed.
This is not a problem, the candidates for files are now like:
(foo . "/full/path/to/foo")
.The problem is that when choosing an entry helm is trying to visit
only the filename. helm is opening an empty buffer in
default-directory' that has the same name of the selected entry.
No, see above, when visiting a file e.g with find file, helm use the
cdr
of the candidate, that is the full path even if on your display
you see only the basename of candidate.Too weird that i'm the only one having this problem!
Try to be sure to not have some old library or personal stuff that load
when requiring helm. (e.g An old helm-files.el in your load path)
Try to send as explained in precedent post a full recipe:
--8<---------------cut here---------------start------------->8---
emacs -Q
(add-to-list 'load-path "/path/to/helm/dir") ; be sure to have only
; recent versions of files
; there.
(require 'helm-config)
M-x helm-for-files
Move to files in current directory source?
Try to open a file from there?
What happen?
etc...
--8<---------------cut here---------------end--------------->8---
Using GNU Emacs 24.0.96.1 on LMDE
Try to upgrade to 24.1, but it is not the problem I think; should works
with 24.0.96 too.
Reply to this email directly or view it on GitHub:
#59 (comment)
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
from helm.
The issue is fixed by commit a4f260...
from helm.
Related Issues (20)
- Error with helm-core : Symbol’s function definition is void: def-edebug-elem-spec HOT 7
- follow-mode messes up Emacs' buffer-list, pseudo-randomized order of buffers on each Helm invocation. HOT 1
- :exit-function called with 'exact STATUS when completion-at-point called on already completed sole completion candidate HOT 9
- Emacs' "while-no-input" prevents discoverability/debugging of all Helm funcs invoked after "helm-update" HOT 7
- helm-source-in-buffer drops last entry when first pattern is negated HOT 3
- when annotation is used with completing-read, negating first pattern yields a "ghost" candidate at top HOT 7
- Endless loop in 'helm-fuzzy-default-highlight-match-1' HOT 4
- endless loop in 'helm-candidates-in-buffer-search-default-fn', re-search-forward HOT 1
- "helm-split-window-default-side 'other" and helm-always-two-windows HOT 3
- helm-find-files fails with invalid-function without-remote-files HOT 9
- helm-find-files-get-candidates is failing since helm-20240407.1400/ HOT 4
- helm-run-after-exit not passing the previous match keyword into next helm session, only if previous match is not result. HOT 9
- Helm buffers path format. Visual clutter. HOT 3
- helm-M-x-execute-command: Symbol’s function definition is void: \(setf\ set-buffer-modified-p\) HOT 4
- Extra space is inserted to helm completion in shell mode HOT 3
- Error msg "Key sequence M - m SPC h SPC d SPC m starts with non-prefix key" HOT 5
- Helm commands fail with truncate-string-ellipsis since todays build HOT 3
- `helm-delete-char-backward` does not support `delete-active-region` HOT 2
- helm-occur stopped to work with Emacs 29 HOT 4
- Error: Symbol’s value as variable is void: helm-ff-edit-marked-files-fn HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helm.