when annotation is used with completing-read, negating first pattern yields a "ghost" candidate at top about helm HOT 7 CLOSED

Thanks so much! It's not a huge bother now that #2650 is fixed since I can just avoid choosing the ghost candidate, but I do appreciate you doing such a fantastic job with helm!

1. ( ) text/plain (*) text/html What happened? This is a follow-up to #2650. I noticed the issue in org-roam, where if I was searching for a node and tried to negate the pattern, I would get an empty candidate at the top. Previously, I would also lose my last candidate, but that has been fixed in #2650. I was able to isolate this to how helm interact with annotation-function when it is used as a replacement for completing-read. Side note: when I tried to reproduce this in a clean emacs, the bug from #2650 also resurfaced, but I suspect that that fix has simply not made its way into NonGNU-ELPA. How to reproduce? First, define some simple annotation functions (defun good-annotator (string) nil) (defun bad-annotator-silent (string) "") (defun bad-annotator-loud (string) "hello") Next, enable helm-mode (helm-mode 1) Now, run the following example (let ((completion-extra-properties '(:annotation-function bad-annotator-loud))) (completing-read "Prompt: " '("foo" "bar" "baz"))) The candidate list is initially foohello barhello bazhello but if we try to negate that with !xy, a new entry appears at the top and it becomes hello foohello barhello bazhello

What happened? This is a follow-up to #2650. I noticed the issue in org-roam, where if I was searching for a node and tried to negate the pattern, I would get an empty candidate at the top.

Side note: when I tried to reproduce this in a clean emacs, the bug from #2650 also resurfaced, but I suspect that that fix has simply not made its way into NonGNU-ELPA.

1. ( ) text/plain (*) text/html Should be fixed now by f93f44c, thanks for the recipes, let me know if it is now working for you. Has this not been pushed yet? The most recent commit I see is 4afb13e but it's about 20 hours old and the bug still seems present in that version.