Enforce or change you indention style about helm HOT 8 CLOSED

Mix of tabs and spaces? That's almost never a good idea. I think that in the last few years almost all indentation styles have converged upon the "spaces only for indentation" style. Enforcing the style is a good idea, though.

from helm.

Jonas Bernoulli
[email protected]
writes:

I just noticed that you indent using spaces only.

My preference is to spaces only.
I think Le fixed this with a local variable.
Otherwise, please just untabify when you make changes

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

from helm.

@thierryvolpiatto I did fix it. In my commit message I mentioned fixes #5. That's why see the commit in this thread. See github issues for details.

from helm.

I have no problem with spaces-only if it is enforced; like it is now. But

Otherwise, please just untabify when you make changes

caused a lot of problems in the past, I think.

The indentation is messed up a lot in helm-config.el. These problems have nothing to do with whether one prefers tabs or spaces or both - but I have a feeling that they might result from carelessly converting from one to the other. Anyways, that should no longer be a problem as the preferred style is now enforced. I will send a new pull request with the cleanup.

from helm.

Jonas Bernoulli
[email protected]
writes:

I have no problem with spaces-only if it is enforced; like it is now. But

Otherwise, please just untabify when you make changes

caused a lot of problems in the past, I think.

The indentation is messed up a lot in helm-config.el.

Mostly the result of renaming anything to helm e.g with &key arguments
in many functions like helm-comp-read.

These problems have nothing to do with whether one prefers tabs or
spaces or both - but I have a feeling that they might result from
carelessly converting from one to the other. Anyways, that should no
longer be a problem as the preferred style is now enforced. I will
send a new pull request with the cleanup.

---

Reply to this email directly or view it on GitHub:
#5 (comment)

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

from helm.

Didn't think about this :-)

from helm.

While I am at it... do you want to keep:

(defface helm-apt-deinstalled
....'((t (:foreground "DimGray")))
.."*Face used for apt deinstalled candidates."
..:group 'helm)

instead of

(defface helm-apt-deinstalled
..'((t (:foreground "DimGray")))
.."*Face used for apt deinstalled candidates."
..:group 'helm)

from helm.

What about:

(flet ((some-function (args)
.........fn-code))
..using-fn)

which indent-region "corrects" to:

(flet ((some-function (args)
......................fn-code))
..using-fn)

I like the former better too, but usually just use:

(flet ((some-function
.........(args)
.........fn-code))
..using-fn)

so that I and indent-region agree on how this is supposed to be indented.

from helm.