Git Product home page Git Product logo

Comments (6)

thierryvolpiatto avatar thierryvolpiatto commented on August 27, 2024

these variables are used internally by pcomplete and are needed.
`pcomplete-suffix-list' is needed on emacs-23, so we keep it for compatibility.

from helm.

tarsius avatar tarsius commented on August 27, 2024

Okay so they are used by pcomplete internally.

But why do we need a dynamic value for them? Especially since they are initialized to be eq to the global values and then never changed.

from helm.

lewang avatar lewang commented on August 27, 2024

@tarsius The code implies they could be changed under some circumstance and the original value needs to be saved. Do you know for sure they will never be changed?

from helm.

tarsius avatar tarsius commented on August 27, 2024

No, but who do you expect to change them?

If the values are potentially changed by some code called by helm-esh-get-candidates then I agree. (Edit: I assume this is the case just want to make sure.)

If some code that is part of pcomplete changes it then this is either a feature or a bug of pcomplete.

Finally if the local bindings are there to protect against changes made to these variables elsewhere (not by pcomplete internal code and not from within helm-esh-get-candidates) then this obviously does not work.

from helm.

thierryvolpiatto avatar thierryvolpiatto commented on August 27, 2024

Jonas Bernoulli
[email protected]
writes:

Okay so they are used by pcomplete internally.

But why do we need a dynamic value for them?

You have to wrap all `pcomplete-completions' calls with these
initialized values.
Expect bugs if you don't.

Especially since they are initialized to be eq to the global values
and then never changed.
They are changed internally by pcomplete during the process.
However, it behave differently between emacs23 and 24.
The code have been heavily modified in emacs24.
So indeed some value are never changed in your emacs version but maybe
used and changed by pcomplete in other emacs versions.

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

from helm.

tarsius avatar tarsius commented on August 27, 2024

Okay fair enough.

from helm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.