Comments (6)
these variables are used internally by pcomplete and are needed.
`pcomplete-suffix-list' is needed on emacs-23, so we keep it for compatibility.
from helm.
Okay so they are used by pcomplete internally.
But why do we need a dynamic value for them? Especially since they are initialized to be eq to the global values and then never changed.
from helm.
@tarsius The code implies they could be changed under some circumstance and the original value needs to be saved. Do you know for sure they will never be changed?
from helm.
No, but who do you expect to change them?
If the values are potentially changed by some code called by helm-esh-get-candidates
then I agree. (Edit: I assume this is the case just want to make sure.)
If some code that is part of pcomplete changes it then this is either a feature or a bug of pcomplete.
Finally if the local bindings are there to protect against changes made to these variables elsewhere (not by pcomplete internal code and not from within helm-esh-get-candidates
) then this obviously does not work.
from helm.
Jonas Bernoulli
[email protected]
writes:
Okay so they are used by pcomplete internally.
But why do we need a dynamic value for them?
You have to wrap all `pcomplete-completions' calls with these
initialized values.
Expect bugs if you don't.
Especially since they are initialized to be eq to the global values
and then never changed.
They are changed internally by pcomplete during the process.
However, it behave differently between emacs23 and 24.
The code have been heavily modified in emacs24.
So indeed some value are never changed in your emacs version but maybe
used and changed by pcomplete in other emacs versions.
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
from helm.
Okay fair enough.
from helm.
Related Issues (20)
- `helm--completing-read-default` seems to strip text properties HOT 3
- helm with a list of sources can only select candidates from the first source in the list HOT 2
- helm-echo-input-in-header-line UI bug. HOT 27
- Cannot pre-set 'follow attribute HOT 3
- Error with helm-core : Symbol’s function definition is void: def-edebug-elem-spec HOT 7
- follow-mode messes up Emacs' buffer-list, pseudo-randomized order of buffers on each Helm invocation. HOT 1
- :exit-function called with 'exact STATUS when completion-at-point called on already completed sole completion candidate HOT 9
- Emacs' "while-no-input" prevents discoverability/debugging of all Helm funcs invoked after "helm-update" HOT 7
- helm-source-in-buffer drops last entry when first pattern is negated HOT 3
- when annotation is used with completing-read, negating first pattern yields a "ghost" candidate at top HOT 7
- Endless loop in 'helm-fuzzy-default-highlight-match-1' HOT 4
- endless loop in 'helm-candidates-in-buffer-search-default-fn', re-search-forward HOT 1
- "helm-split-window-default-side 'other" and helm-always-two-windows HOT 3
- helm-find-files fails with invalid-function without-remote-files HOT 9
- helm-find-files-get-candidates is failing since helm-20240407.1400/ HOT 4
- helm-run-after-exit not passing the previous match keyword into next helm session, only if previous match is not result. HOT 9
- Helm buffers path format. Visual clutter. HOT 3
- helm-M-x-execute-command: Symbol’s function definition is void: \(setf\ set-buffer-modified-p\) HOT 4
- Extra space is inserted to helm completion in shell mode HOT 3
- Error msg "Key sequence M - m SPC h SPC d SPC m starts with non-prefix key" HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from helm.