Git Product home page Git Product logo

fcc-options-app's People

Contributors

andrealonzo avatar em-ant avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

fcc-options-app's Issues

Concurrency issues

When 2 people are logged in and making changes in the app, the changes between the users will not be in sync. This will need to inaccurate states. Here are our proposed solutions:

  1. Leave as-is
    Trust that the users know that only one person can use the system at a time.
  2. Only have 1 user logged in at a time
    NOT POSSIBLE
    If someone is currently logged in, another user cannot log in
  3. Allow only write access to one user
    The latest logged in user will have write access
  4. Implement version control
    If the underlying state has changed, notify the user to reload the page. This is similar to version control such as Git.
  5. Concurrent operations between users
    Users can see updates between users in real time. This is similar to Trello or google docs.

Clicking on a consumer doesn't open cluster info window

Right now, cluster info windows open only if the cluster is in the currently viewable map. If you try to click on a consumer that is in a cluster that is not in the viewable map, the map will just pan to the cluster, but the info window will not appear.

This bug is happening because clusters outside the currently viewable map don't get calculated. I think the best way to handle this is to do the following:

  1. Pan to the consumer marker
  2. Wait til the cluster is generated
  3. Check if marker is in a cluster
  4. Open cluster info window if marker is in a cluster

Calculate total available seats

When adding/editing a consumer or edit/deleting a vehicle, let the user know there are not enough seats to fit all the consumers in the database?

Ability to add new waypoints to route

These are our thoughts on how to implement this Trello card:

"as a user I should be able to add a stop to a route to drop off or pick up a consumer from their worksite/ job in the community."

Vehicles edit form is not working as it should

After editing a vehicle, if you edit that vehicle again the form shows the initial data (i.e. the vehicle before the first edit), not the current (edited) vehicle attributes.
screenshot - 07042016 - 22 09 15

The first vehicle has been updated to {name: My minivan 4, fixedSeats: 9}, then set in edit mode again. The form shows the previus data. The back-end data updates correctly.

No error handling on map page

Currently, there are no errors displayed if you perform an invalid action (i.e. add a wheelchair consumer to a non wheelchair vehicle)

Add more seed data

More vehicles with varying seating configurations as specified by Option's Inc.
More consumers located in other areas around Options, Inc (Elk River, Monticello,...)

Adding consumer to deleted vehicle on map shows no errors

Open 2 browsers
Browser 1: open vehicles page
Browser 2: open map
Browser 1: delete a vehicle
Browser 2: add consumers to the deleted vehicle

The map shows no errors, and it looks like the consumer is added to the vehicle.

If you refresh the map, the vehicle is removed and the consumer has the unassigned state.

Issue Editing Vehicle

When editing a vehicle, the form fields get reset to the original fields during loading. The fields should remain the same during the request. The fields should only reset when there is a request failure.

Editing vehicles max seats (or wheelchairs) can lead to wrong state

Example: If you have 5 consumers on Van 1, and you edit that van properties setting maxSeats to 3, you get an incorrect state. Before editing we should check for state coherence, and if an incorrect situation is requested, we should abort the update maybe asking to remove the surplus consumers first.

Adding identical consumer to 2 vehicles doesn't give an error

I see that if you open 2 browsers and try to add the same consumer to 2 different vehicles, the consumer is added to the last vehicle, and removed from the 1st vehicle.

If the consumer is already on a vehicle, I think there should be an error when trying to add the consumer to another vehicle. What do you think @Em-Ant?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.