elving / hackerank Goto Github PK

The link in the text of the "header" of this repo goes to a spam domain.

Nice app!

Couple of issues:

1. The hacker-repo-name should always link to the github repo.
   Try this:

hacker.repoUrl=hacker.repoUrl || ["https://github.com", repo.username, repo.name, ""].join("/");

around line 525 of app.js

2. Sometimes there is an Error message in the console.log:

Uncaught TypeError: Cannot read property 'owner' of undefined

at app.js:515

Might need to guard against this with something like:

repo = repos.shift();
if (!repo) { return; }

or

repo = repos.shift() || {owner:"NOBODY"};

Let me know if you'd like me to put in a Pull Request for these changes.

->> Josh <<-