elliotcubit / golords Goto Github PK

Right now, when the bot restarts, we blindly trust that the first counting number we see is correct. This is obviously not good.

Store the "previous" number in a new table. It should be read in when the bot first starts, and it should only be stored when the bot shuts down. (Though, it wouldn't be the worst thing if it was always an accurate count that updated with every new message, as we could also store the all-time maximum in this table to allow some command to see that)

:(

It would be nice to use Travis CI for this, since it can be gotten for free via github student

• Switch from using user String()s to using their IDs in the database so we don't have to cleanse names. Right now, ''james and 'james will overwrite each other in the databse

• Add some methods to convert from a user's ID to their string identifier. It would be nice to use nicknames where we display a String() instead of user#discriminator. User ID is definitely unacceptable, as it's a long string of numbers

• ^ Make all the changes associated with that throughout the codebase

Sometimes, people will send messages at almost the exact same time. This leads to weird things happening, like:

• Multiple people penalized for messing up
• The wrong person being penalized alltogether
• The bot not marking mistakes when it should

This could be solved by comparing incoming messages by their timestamps which are encoded into the message ID, but implementation will be weird.

• Do we just cache the messages and compare them later?
• When is it safe to accept a message is definitely the correct or wrong answer?
• What should we do if timestamps are identical to the millisecond (or whatever precision discord timestamps are)
• other concerns?

Everyone shouldn't be able to run certain commands. Add a way to discriminate between admins and non-admins with respect to the bot.

Example:

!mybeans
:: 1000 (No change from last check)

!mybeans
:: 1500 (+500 from last check)

!mybeans
:: 700 (-800 from last check)

Add a command that lets us set the learn to count channel. This channel should be stored in a new table along with the serverID. There should only be one counting channel per server.

It would also be nice to print out a menu when !shop is called without an argument for what's being bought.

List cool ideas for server shop things here.

Rob: Mute target member for 60 seconds

Clean up the help string. It's gotten very messy.

Something like Rythmbot's "!settings" would be really good to see -

The biggest problem here is for querybeans. Since there are several commands associated with the module, they're all printed out in one go with no explanation for what the different commands do. It's unusable.

The cases for the big switch in querybeans should be split into multiple functions or files to make things more readable/ modular

Maybe we could use discord embedded messages to make it cute?