*gettext macros fail with string sigils about gettext HOT 5 CLOSED

Weird, I thought we macro expanded them?

from gettext.

We do, I'm not sure why this happens. I'll investigate!

from gettext.

@josevalim ok it's because

Macro.expand (quote do: ~s(foo)), __ENV__
#=> {:<<>>, [], ["foo"]}

but we check for is_binary(msgid) after expanding. I can manually check for the {:<<>>, _, [binary]} pattern.

from gettext.

Yes, we need to check for :<<>> as long as all entries are binaries. I will update sigil_s to return a binary if such is guaranteed.

from gettext.

Closed by 2f183e3! /cc @josevalim

from gettext.