Gettext.PO.Entry about gettext HOT 4 CLOSED

While I thought contexts (msgctxt) were a pretty useful feature in gettext, @josevalim told me on IRC that they're not seen as a very good thing because they can easily cause confusion.

This may make the Gettext.PO.Entry less useful since now it would only wrap a Translation/PluralTranslation and add information on comments. We could just create a %Gettext.PO.Comments{} struct which we can put in the :comments field of both Translations and PluralTranslations.

from gettext.

Also, we can do map polymorphism. I.e., even if we have both Translation and PluralTranslation, functions that work with comments will work as long as both store them in the :comment key. :)

from gettext.

Oops, closed accidentally. But anyway, I don't think we need this. At least not for now!

from gettext.

@josevalim you were right closing this; as I said myself above, without contexts a :comment field is enough and indeed, map polymorphism makes it even cleaner. Thanks for the feedback! I'm closing this for now.

from gettext.