Problem

We need to look at the output to understand what happened

Proposal

GitHub supports an inline check hint https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#create-a-check-run

Prior Art (Optional)

No response

Could require:

• Class: Changes title format. Wouldn't need to be too clever, just look for a word/phrase and colon at the beginning probably
• A change to an AppData file. Would need an opt-out when there are no user-facing changes, maybe.
• No changes to po files (since that's managed by Weblate)
• Updated screenshot? Would need an opt-out when there are no user-facing changes.
• …anything else?

The idea is to help us not miss common style/process things.

If we ever want to set the action up to release to an older codename, we can't.

See: https://github.com/elementary/appcenter/blob/d8d1d80affb6f440d71a896f2fae63772151fb06/debian/changelog#L117

Ideally editing the toplevel comment with something like:

---
[Commits Since Last Release](https://github.com/elementary/wingpanel/compare/2.2.5...master)

It would make it easier for reviewers to verify that release appdata contains all the changes etc

It's redundant. :)

Each PR commit ends in ex. (#123). Outside of GitHub, I'm not sure the PR number is valuable or obvious as to what it is. We could probably strip it.

i.e. see: https://github.com/cassidyjames/ideogram/blob/2df53acf199242a368a1b559acbed7afe503031a/debian/changelog

Thoughts?

See: elementary/files@aa262e3

I think we need whitespace here maybe:

Problem

These changelogs are mostly useful for maintainers and packagers but we're using the user-facing release notes from metainfo. We also now have the problem that the release action doesn't know what to do with the issues tag

Proposal

While the release action has been broken for creating release tags we've been using Github's automatic release notes generation and it's been fine? It does a good enough job just summarizing the commits and it's kinda neat that it has like "so and so made their first commit in this release" kind of stuff. So we probably don't actually need to be doing anything fancy here?

Prior Art (Optional)

See also #24

What Happened

It looks like tagging releases is broken

Expected Behavior

We should get a release tag on GitHub

Logs

See https://github.com/elementary/gala/runs/3305400983?check_suite_focus=true and in particular:

  "message": "Must specify access token via Authorization header. https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param",
87
  "documentation_url": "https://docs.github.com/v3/#oauth2-token-sent-in-a-header"

AppCenter is going to switch its packaging system from Debian Packaging to Flatpak. So it would be nice if Gettext Actions no longer requires existence of deb-packaging branch.

It seems like required because we use it to install dependencies listed in debian/control

Prerequisites

• I have searched open and closed issues for duplicates.

Describe the bug

Action should fail if meson returns non 0 exit code. I got this issue with gettext action. Might affect others too.

Expected behavior

Action should fail.

Additional context

The following action failed to update translation template due to meson.build:37:6: ERROR: Script or command 'meson/post_install.py' not found or not executable, however Action completed with a success response.
https://github.com/arshubham/cipher/commit/cfb48b0d1ff2457b9462878dc5c79971e876f8ef/checks?check_suite_id=313032511

See: https://github.com/cassidyjames/ephemeral/runs/820211869#step:4:1

and: https://github.com/cassidyjames/ephemeral/blob/main/.github/workflows/gettext.yml

The Release action should not duplicate lines in any given release's Debian changelog. It looks like we can filter the commits in bash somewhere around here:

For an example of duplicate lines in a changelog, see: https://github.com/elementary/appcenter/blob/d8d1d80affb6f440d71a896f2fae63772151fb06/debian/changelog#L24-L25

Prerequisites

• I have searched open and closed issues for duplicates.

Feature

Is your feature request related to a problem? Please describe.

Editing POTFILES is not automated at the moment, so if we forget to update POTFILES when adding/removing files that include translatable strings, Gettext Actions will fail.

Describe the solution you'd like
It would be useful if the Gettext Actions can detect added/removed files from a project, check if they include translatable strings (_(), ngettext (), dgettext (), etc.), and if so remove/add the path to them from POTFILES automatically.

Existing work
N/A

Describe alternatives you've considered
N/A

Additional context
N/A

See: https://github.com/cassidyjames/ideogram/blob/2df53acf199242a368a1b559acbed7afe503031a/debian/changelog#L4

What Happened

Specifying the version of granite as 6.0.0 in meson.build like this causes the build failing with the following error:

meson.build:25:0: ERROR: Invalid version of dependency, need 'granite' ['>=6.0.0'] found '5.5.0'.

Seems like the package name is libgranite6 but its latest release for odin daily is 5.5.0.

Expected Behavior

The build succeeds (and the CI should pass).

The GitHub checkout@v2 action sets the credentials on the repo differently, meaning that doing this does not work anymore:

This means that the action can no longer push to protected branches using the elementaryBot token.

Reading this suggests that adding a git credential helper instead should be the solution to this problem:
actions/checkout#162

So it looks like we can add something like this instead:

git config credential.https://github.com/.helper "! f() { echo username=x-access-token; echo password=$GITHUB_TOKEN; };f"

We should be able to change this in the actions config

It silently fails if it is unable to commit changes, and thus the action looks like it succeeded.

Much like the lint action, it would be handy to provide an AppStream data validation action so we can ensure things are valid before they're merged. Would avoid issues with malformed AppData, missing tags, etc.

https://github.com/elementary/installer/runs/469330213

Waits for a user prompt that it never receives

Describe the bug

I've noticed with how release notes are now being handled they basically never contain information that pertains to changes in the buildsystems/dependencies.

I prime offender would be https://github.com/elementary/wallpapers/releases/tag/5.5.0, which Meson build system support was added and there's no mention of this. This is particularly frusterating for me as a distro maintainer, changes in the build system or dependencies are often the most important information.

I do understand this is performed in a more automated way, so it would be nice if this information could be included again. Otherwise I actually have to manually read the git log for this information on the relevant files.

Thanks. worldofpeace ✨

Please use the Authorization HTTP header as using the access_token query parameter is deprecated and will be removed July 1st, 2020.

Visit https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters for more information.

GitHub has moved to main as the default branch name; however, this line assumes master, and is not configurable:

Is there a way in git to get the primary/default branch instead of hardcoding master here? If not, we should make this configurable in the .yml.

Something we're currently doing manually is follow-up commits that run ninja projectname-pot and ninja projectname-update-po.

It would be nice if we could have an automation that would automatically run these (and their extra counterparts) on commit to master and then commit and push the results if there have been string changes.

We previously discussed in slack that we can determine if there are significant changes because lines we don't care about are all prefixed with a # char

i.e. see https://github.com/elementary/videos/releases/tag/2.7.0; it was originally created as

• New features:
• Option to automatically play next videos
• Navigate the playlist with the keyboard
• Add a button to clear the playlist
• Show audio track language in settings
• Show playlist item titles in their tooltips
• Other updates:
• Show an error for unsupported files
• Fix disappearing cursor on headerbar
• Hide seekbar preview when switching windows with Alt + Tab
• Translation updates

I manually edited it to read

New features:

• Option to automatically play next videos
• Navigate the playlist with the keyboard
• Add a button to clear the playlist
• Show audio track language in settings
• Show playlist item titles in their tooltips

Other updates:

• Show an error for unsupported files
• Fix disappearing cursor on headerbar
• Hide seekbar preview when switching windows with Alt + Tab
• Translation updates

… which better matches the appdata

https://github.com/elementary/videos/blob/81cd005eb4e3fbdd8acd07adbbfed5f3bb83aa04/data/io.elementary.videos.appdata.xml.in#L63-L81

Prerequisites

• I have searched open and closed issues for duplicates.

Feature

We could possibly speed up a lot of our ci runs by pre-building the actions images, so that each pipeline doesn't have to build the docker image every time (they'd just fetch the existing image). Not sure what kind of performance gains we could get with this, but I think it'd probably be a significant enough speed boost to investigate!

Shouldn't it?

Or else we should update the README to show that you need both this action and checkout

It would be super convenient if we could also close the related milestone (if it exists).

For example, we release "1.0.0", then we close the milestone named "1.0.0"