ekumen-os / andino_integration_tests Goto Github PK

Desired behavior

We should not be using pandas to present the tests that run in RoboMaker, we could achieve the same with just string templates.

Alternatives considered

N/A

Implementation suggestion

Use pure python to achieve the same and save CI time when installing the dependencies.

Additional context

N/A

Environment

• OS Version: Ubuntu 22.04
• Source or binary build: source build, but in CI.

Description

• Expected behavior: we have a hardcoded path to change directory within the docker container.
• Actual behavior: we should be able to do the same using other action variables.

Issue happening here and here.

Steps to reproduce

N/A

Output

N/A

Desired behavior

It would be nice to have the role configurations in the repository for documentation purposes and to speed up the ramp up with a similar configuration.

Alternatives considered

N/A

Implementation suggestion

N/A

Additional context

N/A

Desired behavior

We should not waste time in CI and wait until the simulation jobs timeout. Instead, we should tag jobs and cancel them once they are finished.

That has some implications:

• We should tag simulation jobs based on the test result.
• We should trigger a cancellation once are tagged.
• We should not flag jobs that were cancelled because of a tag as failures.

That should save considerable amounts of time and money.

Alternatives considered

N/A

Implementation suggestion

N/A

Additional context

N/A

Desired behavior

In order to make a little bit more user friendly in terms of knowing which jobs failed from the report given on the PRs, it would be nice to add the test name to the report that way users can identify faster which test failed.

Alternatives considered

N/A

Implementation suggestion

N/A

Additional context

N/A

Environment

• OS Version: CI
• Source or binary build?

Description

• Expected behavior: CI should pass
• Actual behavior: CI is failing it raised andino_bringup: Cannot locate rosdep definition for [rosbag2-storage-mcap]

Environment

• OS Version: N/A, in CI
• Source or binary build: N/A

Description

• Expected behavior: the message that is displayed when the ECR image is created and the ARN pointed to when removing the docker image used in the simulation jobs should point to the right repository.
• Actual behavior: it is pointing to another one as a result of the release process, that got outdated.

Steps to reproduce

N/A

Output

Desired behavior

For completion, it'd be nice to benefit of that scheme and run it as AWS RoboMaker proposes as well.

Alternatives considered

N/A

Implementation suggestion

N/A

Additional context

N/A

Environment

• OS Version: N/A, CI
• Source or binary build? N/A CI

Description

• Expected behavior: when removing the simulation jobs, the robot and sim apps should point to the right names.
• Actual behavior: the repository name is being used instead of the actual variable that comes from other jobs setting those names.

See https://github.com/Ekumen-OS/andino_integration_tests/blob/main/.github/workflows/remove_robomaker_simulations.yml
This is a left over after the release.

Steps to reproduce

N/A

Output

N/A

Desired behavior

This package would be great to have it as a python package.

• Create a python package for this collection of scripts.
• Update format.
• Run linter and copyright tests.
• Add tests.

Also, it might be worth moving it outside this repository.

Alternatives considered

N/A

Implementation suggestion

N/A

Additional context

N/A

Desired behavior

The code only covers the case where andino moves forward, we need other test cases for moving backwards and combining it with rotations.

Cases to cover:

• The robot moves backwards in a straight line.
• The robot rotates in place clockwise.
• The robot rotates in place counterclockwise.

Alternatives considered

N/A

Implementation suggestion

Create new test cases for each movement procedure.

Additional context

N/A

Desired behavior

Just what the title says, we should measure and assign some time as a timeout to each stage to make sure that nothing runs forever.

Alternatives considered

N/A

Implementation suggestion

N/A

Additional context

N/A

Desired behavior

Due to the limitations of the Setup script accepting only strings and not lists, the project participants were added to setup.py file as a string.
We project to change the implementation to tackle this problem as a previous step to offer the code as a pip package.
https://docs.python.org/3/distutils/setupscript.html
https://martin-thoma.com/pyproject-toml/
https://stackoverflow.com/questions/9999829/how-to-specify-multiple-authors-emails-in-setup-py

Alternatives considered

N/A

Implementation suggestion

N/A

Additional context

N/A