Git Product home page Git Product logo

Comments (9)

ekristen avatar ekristen commented on June 14, 2024

@YuriGal thanks, on it.

from aws-nuke.

ekristen avatar ekristen commented on June 14, 2024

@YuriGal this is probably why the original nuke doesn't support global filters. How would you like this to behave? Simply warn that it doesn't support it? This could cause filters to be ignored completely. Especially ones defined globally is that acceptable?

from aws-nuke.

ekristen avatar ekristen commented on June 14, 2024

Actually I found the problem. You are right the original nuke just allowed it to continue and logged an warning. I will fix this regression and push an update.

from aws-nuke.

YuriGal avatar YuriGal commented on June 14, 2024

Thanks!

from aws-nuke.

ekristen avatar ekristen commented on June 14, 2024

This should be fixed on the latest beta release https://github.com/ekristen/aws-nuke/releases/tag/v3.0.0-beta.19

from aws-nuke.

ekristen avatar ekristen commented on June 14, 2024

@YuriGal just calling direct attention here so you see it. Thanks for the testing and feedback.

from aws-nuke.

YuriGal avatar YuriGal commented on June 14, 2024

Hi, sorry for the delay, just tried beta.19 - and it works! What's interesting, that list of log errors is much longer now, it shows errors it didn't show before. But it completes successfully.

from aws-nuke.

ekristen avatar ekristen commented on June 14, 2024

No worries on delay. Just wanted to make sure you saw the update. Again appreciate the feedback.

There were errors not previously logged or hidden in the past. I rewrote then underlying library and improved logging across the board.

Feel free to share your output sanitized or you can email me direct at [email protected]

I can review to see if there's room to improve or if there's specific things you are seeing that look off please let me know.

from aws-nuke.

ekristen avatar ekristen commented on June 14, 2024

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from aws-nuke.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.