[Idea] Delete EC2 Instance `Name` Tags On Termination about aws-nuke HOT 5 CLOSED

I've run into this in the past, I think it's just the Name tag that causes the conflict. Removing all the tags would be the easiest approach, I don't immediately see a downside to this approach.

The other option would be to rename the instance to indicate it was terminated by aws-nuke, but that introduces a few extra checks that would have to happen.

from aws-nuke.

@Petersoj when you are working on a PR it's fine generally speaking. You just don't want to be doing force pushes on primary branches/release branches, etc where others are working or where the history is at, when it comes to a new feature and doing a PR, force pushes are normal, because you might amend commits or rebase of the current main branch to make sure you are up to date or to resolve conflicts, etc.

from aws-nuke.

Yeah I imagine removing all the tags on an EC2 instance would fix this issue and not cause any unintended issues.
PR for it: #141 (my first time working in Go which was pretty fun)

from aws-nuke.

hey @Petersoj thanks for your PR, sounds like I need to write up some documentation on how to edit your previous commits so you don't have to close out and re-open, you can always edit and force push to make changes like signing or message syntax.

from aws-nuke.

Yeah I was considering force pushing, but I was reading up on how that isn't the best practice in most cases. Perhaps it was permissible in this case though.

from aws-nuke.