ejsmont-artur / php-circuit-breaker Goto Github PK

Is there a specific reason why there is no mysql storage adapter? I would like to have a central point where all webservers could store and retrieve their circuit breaker information instead of having it local.

I noticed another package not supporting this out of the box as well so am curious if this is a bad idea or not.

/**

• This file is part of the php-circuit-breaker package.
• @link https://github.com/ejsmont-artur/php-circuit-breaker
• @link http://artur.ejsmont.org/blog/circuit-breaker
• @author Artur Ejsmont
  *
• For the full copyright and license information, please view the LICENSE file.
  */

namespace Ejsmont\CircuitBreaker\Storage\Decorator;

use Ejsmont\CircuitBreaker\Storage\StorageInterface;

/**

• This file is part of the php-circuit-breaker package.
• @link https://github.com/ejsmont-artur/php-circuit-breaker
• @link http://artur.ejsmont.org/blog/circuit-breaker
• @author Artur Ejsmont
  *
• For the full copyright and license information, please view the LICENSE file.
  */

namespace Ejsmont\CircuitBreaker\Storage\Decorator;

use Ejsmont\CircuitBreaker\Storage\StorageInterface;
use Ejsmont\CircuitBreaker\Storage\StorageException;

The interface for storage:
https://github.com/ejsmont-artur/php-circuit-breaker/blob/master/src/Ejsmont/CircuitBreaker/Storage/StorageInterface.php
seems not to support atomic operations. Multiple processes on the same machine can interleave like:

1. load value X
2. load value X
1. store value X+1
2. store value X+1

so that X+1 is stored instead of X+2 due to this race condition. Are you aware of this? I was planning to integrate a MongoDB storage but with this interface it won't solve the problem.

Hello,

I had an issue with your project. The isAvailable should remove failures but it reset the time and keep failures. That looks wrong. I guess there is a typo here:
https://github.com/ejsmont-artur/php-circuit-breaker/blob/master/src%2FEjsmont%2FCircuitBreaker%2FCore%2FCircuitBreaker.php#L155

$this->setFailures($serviceName, $failures);

should be

$this->setFailures($serviceName, 0);