egils / cache Goto Github PK

This package is providing its own implementation of the PSR Cache interfaces, but with a different interface than the official ones.
Please mark it as unmaintained on Packagist so that people see this when looking for implementations

The following condition is not implemented since deferred objects are not saved without calling commit() and are lost.

A Pool MUST ensure that any deferred cache items are eventually persisted and data is not lost, and MAY persist them before a Calling Library requests that they be persisted.

Specification mentions couple of possible solutions to this problem. Which ones to implement is yet to be decided.

An Implementing Library MAY use whatever logic is appropriate to determine when to persist deferred items, such as an object destructor, persisting all on save(), a timeout or max-items check or any other appropriate logic.

There are different thinks I noticed while working with this project:

1. Nearly all code in this project uses the short array syntax [] to create new arrays. This syntax was introduced in PHP 5.4 - since many projects, which might depend on this project, support at least PHP 5.3, it might be useful to refactor the project regarding the full syntax.
2. use-clauses are always relative paths. This can lead to problems, when PHP is searching e.g. DateTime in \Egils\Component\Cache\Adapter and not in \.

As PSR-6 specification states deferred but not-yet-persisted objects should be retrievable. As @scento noticed, this is not yet implemented.

Requests for a cache item that has been deferred MUST return the deferred but not-yet-persisted item.

The doctrine adapter does not return an Instance of Psr\Cache\CacheItemInterface, when calling getItem() with an not-existing key, but instead false. The specifications especially refer to this way to request an instance.

A better solution would be an implementation for getItem() like this:

if ($this->provider->contains($key) === true) {
      $item = $this->provider->fetch($key);
      $item->setHit(true);
      return $item;
} else {
      return new CacheItem($key);
}