The sourcefilefinder from egil

sourcefilefinder's People

Contributors

Stargazers

Watchers

sourcefilefinder's Issues

Version conflict detected for Microsoft.CodeAnalysis.CSharp.Workspaces

Describe the bug or question
We are using Microsoft.CodeAnalysis packages V3.7 and we have a nuget restore error because of a version conflict.

Example:
Add the latest Microsoft.CodeAnalysis.CSharp.Features package to the test project.

Results in this output:

Build Error:

2>C:\Repos\Frontend\Tests\Frontend.BlazorControls.Tests.csproj : error NU1107: Version conflict detected for Microsoft.CodeAnalysis.CSharp.Workspaces. Install/reference Microsoft.CodeAnalysis.CSharp.Workspaces 3.7.0 directly to project Frontend.BlazorControls.Tests to resolve this issue. 
2>C:\Repos\Frontend\Tests\Frontend.BlazorControls.Tests.csproj : error NU1107:  Frontend.BlazorControls.Tests -> Microsoft.CodeAnalysis.CSharp.Features 3.7.0 -> Microsoft.CodeAnalysis.CSharp.Workspaces (= 3.7.0) 
2>C:\Repos\Frontend\Tests\Frontend.BlazorControls.Tests.csproj : error NU1107:  Frontend.BlazorControls.Tests -> bunit.xunit 1.0.0-beta-9 -> SourceFileFinder 1.0.0-preview-1 -> Microsoft.CodeAnalysis 3.5.0 -> Microsoft.CodeAnalysis.CSharp.Workspaces (= 3.5.0).

Expected behavior:
There should be no public dependencies for CodeAnalysis packages.

Fix:
Remove the public dependency of CodeAnalysis packages in SourceFileFinder

Version info:

Library version: 1.0.0-beta-9
.NET Core/Blazor version: 3.1

Additional context:
Update the package reference in the project file and set private assets to all.

    <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Features" Version="3.7.0">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
    </PackageReference>
    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="3.7.0">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
    </PackageReference>
```

Recommend Projects