efritz / deepjoy Goto Github PK

It would be awesome to be able to somehow mock out the connections made with the pool using something like redigomock. Maybe an option you can pass into the constructor?

AWS and other redis clusters help with scaling by adding read replicas, so having support for that built-in would be good. Something like WithReadHost() maybe?

1. Rename to ClientConfigFunc
2. Document each config func

I think the logger should default to the nil logger provided by deepjoy, it feels weird for a library to log to stdout by default.

Retry on broken pipe as well.

Encountered runtime error (unnamed process returned a fatal error (write tcp 172.17.0.22:53468->10.113.86.69:6392: write: broken pipe))

The io.EOF error when sending the SEND portion of a transaction is not necessarily flushed. This should be flushed first before checking the error to ensure that if the connection is dead we actually detect it instead of later when we refuse to (since we may have modified something).

Prefix is unnecessary here:

Add a few methods which runs eval, but will send the sha of the script implicitly to reduce bandwidth. This needs to introspect the error from the server in case the sha is unknown, re-send the script, and try again.