Git Product home page Git Product logo

dayofaction-banner's People

Contributors

elliotharmon avatar jpt avatar lschatzkin avatar maximillianh avatar mfb avatar sinak avatar wioux avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

dayofaction-banner's Issues

Keep showing for a while

IMHO it would make sense to not just close the popup when clicking anywhere or waiting a while.
The whole point is to "block" access temporarily, to make the user really feel it for a moment.

I feel that being able to click it away instantly is too easy, especially as this is something for just a day (hopefully!).

So alternatively I'd suggest to either only allow clicking it away after 5 seconds or something, or only by explicitly clicking the buttons. Having it close itself after 5 seconds, as it is now, seems quite pointless to me, especially for people who tend to open pages in tabs and wait for them to fully load.

I really don't feel it's too obtrusive, and since it only happens once per page (as a cookie is stored to remember) it's no big deal to wait those few seconds, giving a user some time to think what it's like when Net Neutrality really goes down.

Some geolocation features would be great

At a glance, if you're not American, the current banners seem to not apply to you and is only annoying. It takes a few clicks to finally see that you can see a message if you're outside the US, but frankly, the FCC should care a lot more if you're American.

With that in mind, it would be great if there was an option to only show the banner to American visitors and/or have a simpler, international version that appears when the visitor isn't US-based.

Embedded petition actions default to US addresses

When you embed a petition action, it defaults to showing a US address, and you have to click “Not in the US?” I can actually hide the US code and show the international section via CSS, but the form validation still fails.

There needs to be some way of embedding an action with this switch already toggled. I can’t do it via js since it’s an iFrame, so we need to change the action center’s embed code to enable embedding an already-toggled-to-international petition.

Update README to reflect EFF URL

Right now the widget links to the github.io widget address. Before going live, this should be updated to the URL that EFF is using to host the widget code.

Update action URLs once they have been published

The petition and email actions currently point to old URLs. These need to be updated once real actions have been published. The URLs are in banner_content/email.html' andbanner_content/petition.html'

Looks a little *too* genuine - users may immediately bounce.

My only concern with the widget is that a casual user landing on my site may not even think to click anything in order to see the second page. I'd suggest a small one liner at the bottom saying something to the effect of "We're only kidding, but to see the serious issue behind why this is here, please click."

Widget gets error

Get "TypeError: n.style undefined" when code is placed in article code page.
What is the best way to embed widget code in Joomla CMS?
Please advise.
Thank you!

Make fully accessible

I'm not sure if this is already the case, as I don't have a screen reader to test this as a blind or partially sighted person, but it would obviously make sense to make the banner legible for all 🎉

Cannot close popup on small mobile display

AFAICT it's not possible to close the popup on a small mobile display - I'm not sure what the cutoff size is where you can or cannot close it.

This means it appears everytime you load a page because it never sets a cookie.

email.html not displaying properly in Tor Browser

I tried filling out the form in Tor Browser. When I click on the "Take Action in the U.S." button, a second tab is opened. (This tab looks odd because the form appears on the right of the window and there is a huge green background otherwise.) Then, after entering my address and zip code, it displays an "Email your representatives" page and this is cut off such that I can't press the "Submit Query" button. Scrolling doesn't work.

Here is a screen shot:
screen shot 2016-06-21 at 6 29 07 pm

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.