The scheduling from eensymachines-in

JSONRelayState now needs bson tags on the datafields

Luminapi core requires the JSONRelayState to be marashalled to a database which means the bson data fields would be important

Co incidence and conflict - need to resolve

See the code documentation here

This section in the code needs a slight change in the conditional check. Coincidental schedules cannot be regarded as conflicting. Yes we may have to make changes to implementation of 2 schedules as well

scheduling/sched.go

Lines 137 to 161 in 5de802a

 func overlapsWith(left, right Schedule) (bool, bool, bool) { 

 var outside, inside, overlap bool 

 // Midpoints are distance of the half time since midnight for any schedule 

 mdpt1, mdpt2 := left.Midpoint(), right.Midpoint() 

 // half duration of each schedule 

 hfdur1, hfdur2 := left.Duration()/2, right.Duration()/2 

 // getting the absolute of the midpoint distance 

 mdptdis := mdpt1 - mdpt2 

 if mdptdis < 0 { 

 mdptdis = -mdptdis 

 } 

 // Getting the larger of the 2 schedules 

 var min, max int 

 if hfdur1 <= hfdur2 { 

 min, max = hfdur1, hfdur2 

 } else { 

 min, max = hfdur2, hfdur1 

 } 

 if outside, inside = (mdptdis > (hfdur1 + hfdur2)), ((mdptdis + min) < max); outside || inside { 

 overlap = false 

 } else { 

 overlap = true 

 } 

 return outside, inside, overlap 

 }

`overlapsWith()` test

Have changed the function to return 3 different values, check the working of the same using various end cases.

eensymachines-in / scheduling Goto Github PK

scheduling's People

Contributors

Stargazers

Watchers

scheduling's Issues

JSONRelayState now needs bson tags on the datafields

Co incidence and conflict - need to resolve

`overlapsWith()` test

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	func overlapsWith(left, right Schedule) (bool, bool, bool) {
	var outside, inside, overlap bool
	// Midpoints are distance of the half time since midnight for any schedule
	mdpt1, mdpt2 := left.Midpoint(), right.Midpoint()
	// half duration of each schedule
	hfdur1, hfdur2 := left.Duration()/2, right.Duration()/2
	// getting the absolute of the midpoint distance
	mdptdis := mdpt1 - mdpt2
	if mdptdis < 0 {
	mdptdis = -mdptdis
	}
	// Getting the larger of the 2 schedules
	var min, max int
	if hfdur1 <= hfdur2 {
	min, max = hfdur1, hfdur2
	} else {
	min, max = hfdur2, hfdur1
	}
	if outside, inside = (mdptdis > (hfdur1 + hfdur2)), ((mdptdis + min) < max); outside \|\| inside {
	overlap = false
	} else {
	overlap = true
	}
	return outside, inside, overlap
	}