Git Product home page Git Product logo

Comments (3)

edward-shen avatar edward-shen commented on September 16, 2024 1

Hello!

I primarily made it a separate module for modularity. I personally don't like it when I need to install some unrelated thing to use a single feature of it.

By splitting up the module into two, I allow people who want to use MMM-page-indicator for their purposes without requiring them to drag in MMM-pages.

MMM-pages is more versatile than you might think. People have used MMM-pages for personalized pages with face recognition, which doesn't make sense to include MMM-page-indicator.

from mmm-pages.

E3V3A avatar E3V3A commented on September 16, 2024

Aha, I see. It just seemed more natural to have a config option like: pageIndicator: true and not have to install and configure a separate module... I also thought you needed to have MMM-pages in order to use the indicator. Thanks for quick feedback.

from mmm-pages.

edward-shen avatar edward-shen commented on September 16, 2024

That's a cost that I've found acceptable. I don't see clean and (more importantly) expected way to ask people to install both.

The issue is that other modules need to add in support for MMM-page-indicators for it to properly work.

Please feel free to make another PR if you have another other suggestions! I'll close this issue for now, but feel free to ask to reopen.

from mmm-pages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.