Git Product home page Git Product logo

Comments (8)

cluelesscarter avatar cluelesscarter commented on August 13, 2024 1

from mmm-pages.

edward-shen avatar edward-shen commented on August 13, 2024

Thanks for the feature request. I don't have a magic mirror present, but these changes were small enough that I think you can help me test them.

Please do the following:

git pull
git checkout default-page

and then look at the updated configuration options in the README.md.

Please let me know if this works.

from mmm-pages.

cluelesscarter avatar cluelesscarter commented on August 13, 2024

Hey @edward-shen

Thanks for this - it works but the Pages-indicator does not display the correct page, on load, the correct homePage is displayed but pages indicator displays the 1st position until you begin navigating.

from mmm-pages.

edward-shen avatar edward-shen commented on August 13, 2024

Thanks for testing it out. Do a git pull and try again—I think I fixed your problem.

If you have a chance, please try out rotationHomePage as well, and let me know if that works. I had to do some config option updating to reflect your request.

from mmm-pages.

edward-shen avatar edward-shen commented on August 13, 2024

Hey, are you still there? I'd like to get this merged into master so everyone can use it, but I'm not able to until I get confirmation that this works.

from mmm-pages.

cluelesscarter avatar cluelesscarter commented on August 13, 2024

@edward-shen Hi Edward, apologies for the slow response I will test it tonight after work!

I'm quite new to github and did a pull request, I think it worked but I'm not 100% sure. I will check again tonight :)

from mmm-pages.

edward-shen avatar edward-shen commented on August 13, 2024

Can I assume everything's working fine?

from mmm-pages.

edward-shen avatar edward-shen commented on August 13, 2024

I'm going to assume this branch is fine, since there hasn't been any complaints since. Merged.

from mmm-pages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.