educastellano / jsonlint-tree Goto Github PK

I think It could be really useful if an exit code is added so this can be used in CI environments :)

something like exit 0 for no errors and exit 1 whenever there are some failures. This way the this could be integrated into the npm scripts of a project for example.

I did this quick hack as a poc, if you like the idea I'll be glad to submit a PR :)

...
if (passed+failed === files.length) {
   ...
   process.exit(failed)
}
...

What do you think?

Add an option to hide files passed validation. E.g. "--quiet" option.

Statistics is not always printed in some directory layouts

A
|- B
   |- file.json

Now run the tool $ jstree-json A

Files array list length is 2, Analyzed files = 1. Condition does not pass.

Exit code does not match count of invalid files if there are more than 255 erroneous files.

Exit code should not exceed 127 on most platforms.
See https://en.wikipedia.org/wiki/Exit_status

It's better to have a fixed error exit code.

The first line of this utility is #!/usr/local/bin/node, a path which is empty on OSX when using Node Version Manager.

Thus, this utility when run on OSX with Node installed via NVM produces--

-bash: /Users/chris/.nvm/versions/node/v4.5.0/bin/jsonlint-tree: /usr/local/bin/node: bad interpreter: No such file or directory

A solution which would help this utility run on the most platforms would be to use this shebang instead--

#!/usr/bin/env node

I typically need this kind of tool for linting json configurations of my project. The problem is that it also lints all json files within node_modules.