editorconfig / editorconfig-qtcreator Goto Github PK

Currently the plugin is not listed on the editorconfig web page, I think it should be.

It was released today, I already miss this plugin.

Keep up with the good stuff 👍

Build for QtCreator 4.5.2 windows plz

The README file claims it's using LGPLv3, but the LICENSE text is GPLv3 --- you should also include the LGPL text. For example, you can rename the current LICENSE file to gpl.txt, and use the LGPL text to fill in the LICENSE file.

Another issue is that the project is licensed under LGPLv3 (ONLY), however, it is recommended to use LGPLv3+, i.e., "LGPL version 3 or any later version at your option", to avoid future compatibility issues when LGPLv[4567] is born. But any way, this is your choice: you can choose to to be incompatible with future versions of (L)GPL.

The final issue is that it is recommended to add the following header to all source files, according to the GPL guideline:

This file is part of EditorConfig QtCreator Plugin.

EditorConfig QtCreator Plugin is free software: you can redistribute it and/or modify
it under the terms of the GNU Lesser General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

EditorConfig QtCreator Plugin is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU Lesser General Public License for more details.

You should have received a copy of the GNU Lesser General Public License
along with EditorConfig QtCreator Plugin.  If not, see <http://www.gnu.org/licenses/>.

In #1 (comment) it was mentioned:

So, in future it will be possible to include the plugin in the QtCreator distribution.

This plugin seems to work, and it would resolve QTCREATORBUG-14013, I guess.

So, any plans for including the plugin into the QtCreator upstream distribution?

I can't build from source on arch linux

$ mkdir build && cd build
$ qmake ../editorconfig.pro 
Cannot read /src/qtcreatorplugin.pri: No such file or directory

Qt Creator 4.11.2 on Windows. Have a CMake project open.

On some some sources files editorconfig doesn't work and this message appears:

editorconfig: Input file must be a full path name.

I'm not sure what is special about these files.

But searching through code for where message comes from first brings me here in editorconfig library:

https://github.com/editorconfig/editorconfig-core-c/blob/6fe393c5b5c8f184c6b6c33e379f3b919b698e0f/src/lib/editorconfig.c#L424

Which is because the absolute path check failed:

https://github.com/editorconfig/editorconfig-core-c/blob/e70d90d045e339374abda3fa664904fbba7f8d67/src/lib/editorconfig.c#L492

... and it probably failed because Qt Creator handed the plugin a relative path in here:

Tried building editorconfig-qtcreator to see actual paths being passed in, but struggled to get a working plugin .dll built. Also can't get qCDebug() output to appear either.

I'd suggest that path handed over by Qt Creator to the plugin might need forced conversion to an absolute path.

But hard to be certain without seeing what path Qt Creator is actually handing the plugin.