editor-js / quote Goto Github PK

I prefer to have quote tool without the caption as it consumes too much space. Would you add a configuration option to hide it?

Btw is this correct that the empty caption is generated?

{
  "type": "quote",
  "data": {
    "text": "a",
    "caption": "",
    "alignment": "left"
  }
}

Try npm i --save-dev @types/editorjs__quote if it exists or add a new declaration (.d.ts) file containing declare module '@editorjs/quote';`
This error is showing for all editorjs files except header and editorjs.

Can you publish other npm packages for typescript

For a valid quote block, can the text, caption, or alignment properties under any circumstances (now or in the future) be null or omitted? Or are they guaranteed to always be present and non-null for this block to be valid?

Context: I'm a back-end .NET developer needing to parse Editor.js documents. The readme lists all of the aforementioned properties, but does not explicitly guarantee that they will always be present and non-null. Back-end deserialization/parsing in strongly typed languages would be easier with some guarantees about which properties can and can not be null/omitted. (Ideally, any such guarantees should be added to the readme to ensure they are formalized and kept in the future.)

Reproduction: change the alignment.

Why it matters: without triggering change event, an auto saving functionality cannot detect and update change of the editor.

I see errors in the Chrome console.

I'm still not sure exactly when this happens. I did the same things in both the quote field and the caption field and got errors.

What I did:

1. Enter a line and press 'Enter'(one or more).
2. In the empty line press 'Backspace'
3. I see the error in the console

But sometimes after the same steps, the error doesn't show. You can see it again if you press 'Enter' more than 2 times, enter a line, place the cursor on a blank line below the first line and press Backspace'

this is my config for quote: { class: Quote, inlineToolbar: true, shortcut: 'CMD+SHIFT+O', config: { captionPlaceholder: this.$t('Author name') // this.$t() - it's i18n translation function }}

I found a small bug :)

When having a new line in the "caption" and deleting it... it shows this "length" error.

It shows exactly when the caption goes from 2 lines to 1 line.

The option to left or centre align the quote content shows however changing the alignment does not seem to do anything.

I have entered two paragraphs inside the quote separated by Enter key. This is the result:

{
  "type": "quote",
  "data": {
    "text": "first paragraphsecond paragraph",
    "caption": "caption",
    "alignment": "left"
  }
}

The best solution would be if Quote supported the nested elements, so there would be two paragraphs. If it is not possible from a technical point of view, then whitespace must not be consumed:

{
  "type": "quote",
  "data": {
    "text": "first paragraph second paragraph",
    "caption": "caption",
    "alignment": "left"
  }
}

The quote manual cdn refers to version 2.0.0

https://cdn.jsdelivr.net/npm/@editorjs/[email protected]

instead of latest

Cant translate "Left alignment" and "Right alignment"

Editor version: 2.7.20
Quote version: 2.1.3

There is no multi line (aka paragraph) support, so every line is concatenated to prev one even without space. But it is common thing to have a long quote, so it looks useful.

Use case:

line1
line2
line3

Expected behavior:

<p>line1</p>
<p>line2</p>
<p>line3</p>

Actual behavior:
line1line2line3

It seems to be an issue that changes on the tune menu (i.e. align) don’t trigger the onChange listener of EditorJS. It was also posted here: codex-team/editor.js#757

hi
i want to use the quote tool without the alignment option. just a quote and maybe a caption.
is there a possibility to remove the alignment option?
thanks for the great work though!