edemilliere / adsi Goto Github PK

Good evening

Thanks a lot for this nice and useful script!, I have a small suggestion:
Your LoadedProperties logic is not reliable because if the 1st returned record does not contain all requested properties, then the result will only contains this property subset.

Therefore, I propose to use $Property if it was passed.
Instead of:

$LoadedProperties = $AllObjects | Select-Object -First 1 | Select-Object -ExpandProperty Properties | Select-Object -ExpandProperty PropertyNames

This is should fix the code:

if($Property) {
  $LoadedProperties = $Property
} else {
  $LoadedProperties = $AllObjects | Select-Object -First 1 | Select-Object -ExpandProperty Properties | Select-Object -ExpandProperty PropertyNames
}

Kind regards, Tom