The feathers-hooks-utils from eddyystop

feathers-hooks-utils's People

Contributors

Stargazers

Watchers

feathers-hooks-utils's Issues

checkContext doesn't support using null for permitted methods.

Docs and comments say that passing null for the permitted methods in the checkContext hook should allow any method to pass, but this case isn't handled properly.

The 'anonymous' hook can only be used on the '[null]' service method(s).

Should be something like this:

module.exports = (hook, type = null, methods = [], label = 'anonymous') => {
  if (type && hook.type !== type) {
    throw new Error(`The '${label}' hook can only be used as a '${type}' hook.`);
  }

  if (!methods) return; //need this to allow null to pass any method

  const myMethods = Array.isArray(methods) ? methods : [methods]; // safe enough for allowed values

  if (myMethods.length > 0 && myMethods.indexOf(hook.method) === -1) {
    const msg = JSON.stringify(myMethods);
    throw new Error(`The '${label}' hook can only be used on the '${msg}' service method(s).`);
  }
};

BTW, really like what you are doing with this repo and a few of your others. I'm starting a big project on feathersjs and was super happy to see you've already done a lot of legwork I was expecting to do myself! So thanks!

Recommend Projects