Git Product home page Git Product logo

react-native-hindsighttrader's People

Contributors

eddielee394 avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar

react-native-hindsighttrader's Issues

quote timerId delay issue

  • if user navigates away from a quote before the first interval fires, the quoteTimerId isn't set, which causes the clear timer action to fail since there's no id to clear yet.

Watchlist chart performance issues

major performance issues being caused by the charts on the WatchlistSymbolList component. Charts are rendering while navigating to other screens, causing overall performance issues. Need to unmount the component (cleanup method in useEffect() maybe?) when navigating away.

Steps to reproduce:

  • Create a new watchlist
  • Perform a symbol search
  • Add 10 new symbols to the active watchlist
  • As more symbols are added, performance decreases and the app begins to lag

Possible solutions
Instead of rendering search component in a modal, we could navigate to the search screen and pop the watchlistsymbol screen from the stack which should unmount the component.

stockscreen features

add a scrollable tab view on the stock screen results displaying the recent news for a ticker, FA info & detailed quote info & maybe options chain similar to TOS?

quote ui delay

when the quote component renders, the api request response is slightly delayed causing NaN display in the latest price field before the data is rendered.

maybe add a loader?

Reducer architecture

I don't feel like the reducer architecture is structured properly. For example, in the watchlist.reducer file, i believe the state is actually being mutated when some of the actions are being fired.

Also, the way the reducer logic is setup for adding & removing symbols should maybe be refactored. Currently ADD_WATCHLIST_SYMBOL actually adds AND removes a symbol from the symbols array, depending on whether the symbol already exists. Which makes the DELETE_WATCHLIST_SYMBOL kind of pointless. Maybe this should be refactored to TOGGLE_WATCHLIST_SYMBOL.

build failure

latest commits cause the following android build failure:
Task :app:transformNativeLibsWithMergeJniLibsForDebug FAILED

refactor chart RANGE constants

i need to figure out a better way to deal with those RANGE constants. I'm trying to avoid using a dedicated global Constants file for component specific constants, as it's a DDD anti-pattern. So i'll mark this one as a todo on the roadmap.

Originally posted by @eddielee394 in #23

refactor assets/images object to use named exports

Got it. Since I'll be removing those svg icons & instead use the react-native-svg-icon lib that's already installed, I'm going to hold off on implementing this suggestion.

Although, requiring each image as a property in the images object, would cause ALL of the required images to be stored in memory whenever images gets imported into a component - so I think this could still be refactored for performance reasons. I'll add this to a separate issue for later.

Originally posted by @eddielee394 in #23

optimize search query return results

currently a large data set is returned when performing a search query causing performance issues. Need to optimize the search process so the full 10,000+ results don't have to be returned and queried through before a result is returned.

setTimeout causing memory leak in stockscreen component

When the setTimeout method starts running it doesn't get cleared when the component unmounts, causing a significant memory leak. If an empty array is passed as a dependency to the hook, the timeout only triggers once and then stops. attempted to run a cleanup function so that the timeout is cleared on unmount, but the timerID keeps changing (hence the timer never being cleared). Need to resolve exactly how to handle disabling a timeout when the component unmounts.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.