eddielee394 / react-native-hindsighttrader Goto Github PK

add a scrollable tab view on the stock screen results displaying the recent news for a ticker, FA info & detailed quote info & maybe options chain similar to TOS?

Got it. Since I'll be removing those svg icons & instead use the react-native-svg-icon lib that's already installed, I'm going to hold off on implementing this suggestion.

Although, requiring each image as a property in the images object, would cause ALL of the required images to be stored in memory whenever images gets imported into a component - so I think this could still be refactored for performance reasons. I'll add this to a separate issue for later.

Originally posted by @eddielee394 in #23

• when creating a new watchlist the data from the current active watchlist persists until a new symbol is added.

currently a large data set is returned when performing a search query causing performance issues. Need to optimize the search process so the full 10,000+ results don't have to be returned and queried through before a result is returned.

major performance issues being caused by the charts on the WatchlistSymbolList component. Charts are rendering while navigating to other screens, causing overall performance issues. Need to unmount the component (cleanup method in useEffect() maybe?) when navigating away.

Steps to reproduce:

• Create a new watchlist
• Perform a symbol search
• Add 10 new symbols to the active watchlist
• As more symbols are added, performance decreases and the app begins to lag

Possible solutions
Instead of rendering search component in a modal, we could navigate to the search screen and pop the watchlistsymbol screen from the stack which should unmount the component.

App does not load and immediately crashes on Samsung Galaxy s10 devices.

• if user navigates away from a quote before the first interval fires, the quoteTimerId isn't set, which causes the clear timer action to fail since there's no id to clear yet.

latest commits cause the following android build failure:
Task :app:transformNativeLibsWithMergeJniLibsForDebug FAILED

I don't feel like the reducer architecture is structured properly. For example, in the watchlist.reducer file, i believe the state is actually being mutated when some of the actions are being fired.

Also, the way the reducer logic is setup for adding & removing symbols should maybe be refactored. Currently ADD_WATCHLIST_SYMBOL actually adds AND removes a symbol from the symbols array, depending on whether the symbol already exists. Which makes the DELETE_WATCHLIST_SYMBOL kind of pointless. Maybe this should be refactored to TOGGLE_WATCHLIST_SYMBOL.

i need to figure out a better way to deal with those RANGE constants. I'm trying to avoid using a dedicated global Constants file for component specific constants, as it's a DDD anti-pattern. So i'll mark this one as a todo on the roadmap.

Originally posted by @eddielee394 in #23

When the setTimeout method starts running it doesn't get cleared when the component unmounts, causing a significant memory leak. If an empty array is passed as a dependency to the hook, the timeout only triggers once and then stops. attempted to run a cleanup function so that the timeout is cleared on unmount, but the timerID keeps changing (hence the timer never being cleared). Need to resolve exactly how to handle disabling a timeout when the component unmounts.

• nav should be persisted

• denounce auto suggest query results on search page to smooth out result rendering

• when adding a new symbol to a watchlist, the symbol is only added to the watchlist state and not the watchlists state;

Hi @eddielee394 ,

how can I get this running with expo? I‘m always failing to start the app on my iPhone.

greets,
Stefan

• implement native splash screen

refactor for typescript support

when the quote component renders, the api request response is slightly delayed causing NaN display in the latest price field before the data is rendered.

maybe add a loader?