Last updates breaks pretext-tools in codespaces about lemminx HOT 13 CLOSED

I can finally confirm that this is fixed and working for me. Thanks all for your work.

from lemminx.

@oscarlevin do you use binary on linux?

If it that I think it is the same problem than redhat-developer/vscode-xml#916

//cc @rgrunber

from lemminx.

In vscode itself, following your example, I get these commands:

And pretty the same command list I have in GitHub codespace with vscode-xml 0.2.6 installed:

Am I messing anything?

from lemminx.

@angelozerr @rgrunber Do you know if vscode-xml running on GitHub CodeSpaces uses any binaries?

from lemminx.

If there's no Java in the container then it would use the binary. If the underlying container environment uses a version of GLIBC < 2.34, then this would be redhat-developer/vscode-xml#916.

from lemminx.

In my case, the vscode-xml extension running on GitHub CodeSpaces has XML> Server: Prefer Binary option NOT selected:

from lemminx.

I suspect that the problem of @oscarlevin is with binary since 0.26.0 doesn't contain major changes.

from lemminx.

In my case, the vscode-xml extension running on GitHub CodeSpaces has XML> Server: Prefer Binary option NOT selected:

What about if you select it?

@oscarlevin could you deselect it in your side to check if it is working for you?

from lemminx.

from lemminx.

Just to be clear, at https://github.com/redhat-developer/vscode-xml/blob/f99df7e859c61256ebd05382f106fc0c5042d1e1/src/server/serverStarter.ts#L28 we do launch the binary even if the choice is not selected. The binary covers the case of not detecting Java on the system but wanting to give a seamless experience. The only time we wouldn't launch the binary is if we detect the current installation has extensions contributing to the LemMinX runtime (because those won't work with the binary mode).

https://github.com/redhat-developer/vscode-xml/blob/f99df7e859c61256ebd05382f106fc0c5042d1e1/src/server/serverStarter.ts#L28 .

@oscarlevin , If possible, you could try the following vsix : https://github.com/rgrunber/vscode-xml/releases/download/0.26.0/vscode-xml-linux-x64-0.26.0-284.vsix . I mentioned it in redhat-developer/vscode-xml#916 (comment) . It is basically 0.26.0 but the Linux binary was built on an older version of Ubuntu for better support of older Linux distros.

from lemminx.

@angelozerr Yes. I can confirm the issue. Turning on the XML> Server: Prefer Binary makes all the commands but the "Open XML Documentation" to disappear . So it looks like a binary problem.

from lemminx.

@oscarlevin @rgrunber For me the vscode-xml extension works fine when installed from https://github.com/rgrunber/vscode-xml/releases/download/0.26.0/vscode-xml-linux-x64-0.26.0-284.vsix :

from lemminx.

Great! Then it very likely will resolve the issue. We've just released 0.26.1 to the marketplaces, and it should contain the necessary fix.

This is mainly a vscode-xml / 3rd party packaging issue as nothing needed to change in lemminx itself.

from lemminx.