Could CloseTagCodeAction offer option to close and result with an empty element. about lemminx HOT 3 OPEN

'm not sure exactly when, so I guess we can leave this issue open for now.

Don't hesitate to ask me if you need some assistance. We have a lot of test with code action, it can be a good start to play with them and write some tests with your future feature.

from lemminx.

The basic idea of close tag action like you have debuged it is to insert the end tag according the fault tolerant parser which set following elements of an element which is not closed as children. You can see that in the outline:

In this case, I want to simply close out the start tag and produce an empty element: <webApplication ... .../>.
I don't want to include the other elements as content.

If I understand, you would like to have a new code action which inserts end tag just after the start tag. Are you interested to implement this kind of code action?

The Liberty Tools Lemminx extension works with server.xml, which is governed by an XSD (similar to this. I don't see this CloseTagCodeAction impl taking this into account either

Indeed close code action doesn't take care of XSD (in lemminx we call that CMDocument which is an abstract of XSD, DTD, RNG, etc), it could be nice to takes care of XSD.

In conclusion I think it could be nice to have:

• startegy 1: a code action which insert after all children (like today)
• startegy 2: a code action which insert teh end tag just after the start tag (your requirement)
• if XML is mapped with a XSD, DTD, try to the proper startegy.

@scottkurz are you interested to work on it?

from lemminx.

The basic idea of close tag action like you have debuged it is to insert the end tag according the fault tolerant parser which set following elements of an element which is not closed as children. You can see that in the outline:

If I understand, you would like to have a new code action which inserts end tag just after the start tag. Are you interested to implement this kind of code action?

@scottkurz are you interested to work on it?

Thank you for your comment and reply. As a start, it's a big help just to hear you confirm I'm understanding this correctly and Lemminx isn't already (supposedly) doing this. I am interested in working on this though I'm not sure exactly when, so I guess we can leave this issue open for now.

In conclusion I think it could be nice to have:

* startegy 1: a code action which insert after all children (like today)

* startegy 2: a code action which insert teh end tag just after the start tag (your requirement)

* if XML is mapped with a XSD, DTD, try to the proper startegy.

Yeah, the last one sounds like to me like a whole other level of complexity, so I would try to start just with 'strategy 2' here. Thx again for your explanation.

from lemminx.