eclipse-openj9 / openj9-omr Goto Github PK

Snapshot branch is stale

I've attempted manually merging but there are some non-trivial conflicts with the OMR code generator.

CONFLICT (add/add): Merge conflict in fvtest/compilertest/tests/CCDataTest.cpp
CONFLICT (content): Merge conflict in compiler/codegen/OMRCodeGenerator.cpp
CONFLICT (add/add): Merge conflict in compiler/codegen/CCData_inlines.hpp
CONFLICT (add/add): Merge conflict in compiler/codegen/CCData.hpp
CONFLICT (add/add): Merge conflict in compiler/codegen/CCData.cpp

While investigating a reported issue of core files not being produced even though supposedly the core hard ulimit was unlimited (waiting on javacore for confirmation), I noticed that unlimitCoreFileSize doesn't check the return result (errno) for the getrlimit and setrlimit calls. It would be nice if it did so and printed a warning if those calls failed.

classNameToSignature in Aliases.cpp checks the L reference. The same change needs to be applied to Q type descriptor. However, the existing API classNameToSignature does not have a TR_OpaqueClassBlock * pointer for us to call ClassEnv::isValueTypeClass to distinguish if the class is a VT or not. classNameToSignature is called in many places in OMR and OpenJ9 and not all callers have access to TR_OpaqueClassBlock * pointer.

char *
classNameToSignature(const char *name, int32_t &len, TR::Compilation * comp, TR_AllocationKind allocKind)
   {
   char * sig;

   if (name[0] == '[')
      {
...
      }
   else
      {
      len += 2;
      sig = (char *)comp->trMemory()->allocateMemory(len+1, allocKind);
      sig[0] = 'L';   <=== // TODO: Need to process Value Type descriptor 'Q'
      memcpy(sig+1,name,len-2);
      sig[len-1]=';';
      }

related to eclipse-openj9/openj9#12237

The Eclipse OMR project (https://github.com/eclipse/omr) is the upstream for the openj9-omr repo. Currently, this repo is updated manually by committers.

We need an automated build that will sync the Eclipse OMR master branch into the openj9-omr master branch. These two branches should always be the same.

Code from the upstream OMR repo is synchronized into the master branch. Once there, we need an automated build that will validate it with openj9 repo and merge it into the openj9-omr repo's openj9 branch.

Hi,

As a member of the Security Team from the Eclipse Foundation, we used a tools Scorecard and StepSecurity to analyze this repo in order to push a pull request that cover some or all the following best practices below:

• Apply least privilege principle to GITHUB_TOKEN
• Add or fine tune the use of Dependabot
• Pin actions to a full length commit SHA

As a result, You will see a PR coming from StepSecurity to help to implement those fixes above which will cover a list of points below identified detected:

• Apply least privilege principle to GITHUB_TOKEN for files .github/workflows/stale.yml
• Add or fine tune the use of Dependabot
• Pin Actions to a full length commit SHA for files .github/workflows/first-interaction.yml, .github/workflows/labeler.yml, .github/workflows/stale.yml, and buildenv/docker/x86_64/ubuntu20/Dockerfile

Please don’t hesitate and reach out if there is something unclear above.

Kind Regards,
Francisco Perez

The fix for eclipse-openj9/openj9#11620 (dc4d2f5) was merged into the openj9 branch but the test case still fails when run against releases which use the v0.24.0-release branch.

While we have an automated build to sync from Eclipse OMR to the openj9-omr repo's master branch, there isn't yet automation to test and promote to the openj9 branch.

A verbose and overly careful process for doing this:

$ git fetch openj9-omr // fetch from the remote
$ git checkout master
$ git rebase openj9-omr/master // ensure local master is up to date
$ git log --oneline // get listing of commits to determine which to promote to the openj9 branch
$ git checkout openj9
$ git rebase master // This MUST be a fast forward merge. If it's not, there's a problem
$ git log --oneline // ensure history is the same as above
$ git reset --hard sha_of_chosen_commit
$ git push openj9-omr openj9 // format is and branch must be openj9

Use this item to track when the openj9 branch is updated.