eclipse-basyx / basyx-dotnet-sdk Goto Github PK

Currently the Creation of Submodels in the SubmodelRepositoryServiceProvider uses an extension method on the Submodel itself to create the Service Provider for that Submodel. But I consider the creation of the Service Provider the task of the SubmodelRepositoryServiceProvider and not one of the submodel.
Furthermore at the moment you could not inject another implementation into the SubmodelRepositoryServiceProvider that would allow a decision about which implementation to use. So the implementation for the service provideer is fixed then.

So my proposal is the following:

• Change the implemntation so that a Factory for service providers gets injected via DI
• The service provider is created using the injected factory
• The default implementation for the factory is the same realisation as currently with the extension method

This way the old behaviour is preserved and the adpatability is enhanced.

@constantinziesche Is there anything that stands against this approach?

Dear all, I am having troubles with cloning the project:

PS C:\Users\-------\source\repos\basyx-dotnet> git submodule update --init --recursive
fatal: remote error: upload-pack: not our ref 42fab265a7fa22660f6ed3595ea0db7ec61751fa
fatal: Fetched in submodule path 'basyx-dotnet-applications', but it did not contain 42fab265a7fa22660f6ed3595ea0db7ec61751fa. Direct fetching of that commit failed.
PS C:\Users\------\source\repos\basyx-dotnet>

Do you have any suggestions for me?

Due to a change in .NET 6 publishing an app using BaSyx causes the following error:

dotnet publish -c Release       
Microsoft (R) Build Engine version 17.0.0+c9eb9dd64 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

  Determining projects to restore...
  All projects are up-to-date for restore.
  SimpleAssetAdministationShell -> /Users/###/SimpleAssetAdministationShell/bin/Release/netcoreapp3.1/SimpleAssetAdministationShell.dll
/usr/local/share/dotnet/sdk/6.0.101/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ConflictResolution.targets(112,5): error NETSDK1152: Found multiple publish output files with the same relative path:
/Users/###/.nuget/packages/basyx.submodel.server.http/1.0.0/contentFiles/any/netcoreapp3.1/Nlog.config, 
/Users/###/.nuget/packages/basyx.aas.server.http/1.0.0/contentFiles/any/netcoreapp3.1/Nlog.config, 
/Users/###/.nuget/packages/basyx.submodel.server.http/1.0.0/contentFiles/any/netcoreapp3.1/ServerSettings.xml, 
/Users/###/.nuget/packages/basyx.aas.server.http/1.0.0/contentFiles/any/netcoreapp3.1/ServerSettings.xml. 
[/Users/###/SimpleAssetAdministationShell/SimpleAssetAdministationShell.csproj]

The .NET SDK generates a new error (NETSDK1152) in cases where files from different source paths would be copied to the same file path in the publish output.

The meta model is now on version 3 (https://industrialdigitaltwin.org/wp-content/uploads/2023/06/IDTA-01001-3-0_SpecificationAssetAdministrationShell_Part1_Metamodel.pdf) and the code base should be updated to reflect this.

In order to keep up with changes in the meta model we need to update the underlying meta model to version 3.

The AAS Core Works project (https://github.com/aas-core-works) provides a source code generator and automatically generated code for C# for the meta model V3 8https://github.com/aas-core-works/aas-core3.0-csharp).

It seems reasonable to include this in the implementation to be ready for future meta model updates and corrections.