Git Product home page Git Product logo

config-typescript's People

Contributors

greenkeeperio-bot avatar niieani avatar

Watchers

 avatar  avatar

Forkers

moverware

config-typescript's Issues

Babel dependency

I see that babel is listed as dependency of this package. However, I don't think using Typescript in webpack needs Babel. Did I understood it incorrectly? In case it's not really needed, I'd appreciate it if you can remove babel dependency.

Add .tsx to resolve.extensions

The loader is testing for .ts and .tsx files test: /\.tsx?$/ but it is only adding .ts to the resolve.extensions

extensions: get(this, 'resolve.extensions', ['.js']).concat(['.ts'])

In order to add .tsx I have to set resolve.extensions in the Webpack config to ['.js', '.tsx'] which isn't very intuitive, but without this, webpack won't resolve .tsx files

config-typescript should also add .tsx to resolve.extensions

TsConfigPathsPlugin should be under resolve: plugins: instead of plugins:

TypeScript was breaking all my configuration file because i (kinda) copy-pasted this code. Adding this plugin inside the plugins array changed his type which was no more a Configuration type. So i did a bit of search to understand the problem.

From @types/webpack

interface Configuration {
...
plugins?: Plugin[];
}

abstract class Plugin implements Tapable.Plugin {
       apply(compiler: Compiler): void;
}

instead the plugin implements (from awesome-typescript-loader)

const TsConfigPathsPlugin: typeof PathPlugin;

export declare class PathPlugin implements ResolverPlugin{
...
apply(resolver: Resolver): void;
}

export interface ResolverPlugin {
    apply(resolver: Resolver): void;
}

This is the first bug i have ever found, so I hope i'm doing all right, otherwise let me know.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.