Comments (4)
Good catch. Must have missed it.
babel-runtime
needs to be a dependency, but extract-text-webpack-plugin
is definitely a devDependency.
Will push a fix soon.
Thanks! 👍
from butter-toast.
Published 2.1.2. Should be fixed now.
from butter-toast.
any reason why you need babel-runtime to be a dependency?
I also noticed you locked down react to a specific version as dev dependency:
"react": "16.2.0",
"react-dom": "16.2.0",
you should move it to peerDependencies without a locked version like so:
"peerDependencies": {
"react": "^16.2.0",
"react-dom": "^16.2.0"
},
from butter-toast.
any reason why you need babel-runtime to be a dependency?
Yes. I use babel transform-runtime
as an alternative to babel-polyfill - which pollutes the global scope. Babel runtime specifically prevents duplication even in shared space.
See here:
This is where the transform-runtime plugin comes in: all of the helpers will reference the module babel-runtime to avoid duplication across your compiled output. The runtime will be compiled into your build.
I also noticed you locked down react to a specific version as dev dependency:
Setting it as devDependency means that npm install won't install react in development, which is unwanted.
Currently this package supports React15. I might add "react": "15.0.0"
as a peerDependency.
from butter-toast.
Related Issues (20)
- Failed to minify the code from this file: HOT 5
- Documentation: how to manually position the tray with CSS? HOT 6
- An in-range update of jest-enzyme is breaking the build 🚨 HOT 1
- Quick repeated clicks on the 'X' generates a warning HOT 6
- An in-range update of enzyme is breaking the build 🚨
- An in-range update of enzyme is breaking the build 🚨 HOT 13
- An in-range update of terser is breaking the build 🚨 HOT 1
- An in-range update of styled-components is breaking the build 🚨 HOT 6
- An in-range update of webpack is breaking the build 🚨 HOT 14
- Prevent duplicate toasts HOT 2
- An in-range update of storybook is breaking the build 🚨
- An in-range update of eslint is breaking the build 🚨 HOT 2
- An in-range update of babel7 is breaking the build 🚨
- An in-range update of eslint-plugin-react is breaking the build 🚨 HOT 4
- An in-range update of storybook is breaking the build 🚨 HOT 23
- An in-range update of eslint is breaking the build 🚨 HOT 2
- An in-range update of terser is breaking the build 🚨 HOT 5
- How to change width? HOT 4
- An in-range update of storybook is breaking the build 🚨 HOT 6
- An in-range update of babel7 is breaking the build 🚨 HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from butter-toast.