Git Product home page Git Product logo

Comments (4)

ealush avatar ealush commented on September 17, 2024

Good catch. Must have missed it.
babel-runtime needs to be a dependency, but extract-text-webpack-plugin is definitely a devDependency.
Will push a fix soon.
Thanks! 👍

from butter-toast.

ealush avatar ealush commented on September 17, 2024

Published 2.1.2. Should be fixed now.

from butter-toast.

juhaelee avatar juhaelee commented on September 17, 2024

any reason why you need babel-runtime to be a dependency?

I also noticed you locked down react to a specific version as dev dependency:

"react": "16.2.0",
"react-dom": "16.2.0",

you should move it to peerDependencies without a locked version like so:

"peerDependencies": {
    "react": "^16.2.0",
    "react-dom": "^16.2.0"
  },

from butter-toast.

ealush avatar ealush commented on September 17, 2024

any reason why you need babel-runtime to be a dependency?

Yes. I use babel transform-runtime as an alternative to babel-polyfill - which pollutes the global scope. Babel runtime specifically prevents duplication even in shared space.
See here:

This is where the transform-runtime plugin comes in: all of the helpers will reference the module babel-runtime to avoid duplication across your compiled output. The runtime will be compiled into your build.

I also noticed you locked down react to a specific version as dev dependency:

Setting it as devDependency means that npm install won't install react in development, which is unwanted.
Currently this package supports React15. I might add "react": "15.0.0" as a peerDependency.

from butter-toast.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.