Hello,

I noticed in your code

You should be aware that python-request is able to handle this (creating url with & between parameters) for you.

Decomposing API requests into 3 parts - base_url, end_point, parameters could be done like

base_url = "http://www.domain.com"
endpoint = "/genre/secondary"
params = {
  "k": k,
  "f": "json",
  "id": genre_id
}

url = base_url + end_point
response = requests.get(url, params=params)

It will be more readable.

Kind regards

Hello @eadwinCode,

I noticed you are using python-requests.
I think you can quite easily implement a way to cache queries using requests-cache

See how it's being used in https://pandas-datareader.readthedocs.io/en/latest/cache.html passing session=None by default or passing session=requests_cache.CachedSession(...)

See also
https://github.com/pydata/pandas-datareader/blob/adb67b2e959f2060a9db18f8b343d06e917f23da/pandas_datareader/_utils.py#L56-L60

Kind regards

Hello,

I noticed

Maybe you should name this environment variable differently to avoid confusion between several API keys.

Generally, environment variables are upper cased.

SHOUTCAST_API_KEY could be a better name for that purpose.

Kind regards

should be

from shoutcast_api import get_stations_by_now_playing
response = get_stations_by_now_playing(api_key, ct='john legend', limit=100, br=128)

Hello,

I'm not a specialist of type annotations in Python, but I noticed you are using them quite intensively in your code.

Maybe you should consider using mypy for statical type checking and add it to your CI pipeline.

mypy can run as a pytest plugin
https://pypi.org/project/pytest-mypy/
(if you consider moving out from unittest to pytest as tests runner)

You should also be aware of https://www.python.org/dev/peps/pep-0585/

Importing those from typing is deprecated. Due to PEP 563 and the intention to minimize the runtime impact of typing, this deprecation will not generate DeprecationWarnings. Instead, type checkers may warn about such deprecated usage when the target version of the checked program is signalled to be Python 3.9 or newer. It's recommended to allow for those warnings to be silenced on a project-wide basis.

The deprecated functionality will be removed from the typing module in the first Python version released 5 years after the release of Python 3.9.0.

Kind regards