function __pfx_new_sync_read has no fentry/mcount call, unable to patch about kpatch HOT 6 CLOSED

repro-1385.tar.gz

I believe the problem is that:

1. new_sync_read() and __pfx_new_sync_read() functions move from ELF section .text.new_sync_read to .text.unlikely.new_sync_read
2. kpatch_compare_correlated_symbol() allows for such movement, marking both new_sync_read and __pfx_new_sync_read symbols as CHANGED
3. kpatch_find_func_profiling_calls() skips __pfx_new_sync_read since is a function "prefix"
4. kpatch_check_func_profiling_calls() checks that all CHANGED STT_FUNC symbols have an fentry/mcount call, including __pfx_new_sync_read which fails because of (3)

Currently testing a fix to amend (4) to skip the fentry/mcount tests on prefix functions.

from kpatch.

If we want such _pfx symbols marked as CHANGED (I think that would be consistent), then kpatch_create_patches_sections() will also have to gloss over them to exclude them from the set of kpatched functions.

See potential fix: joe-lawrence@56152d1

from kpatch.

This issue has been open for 30 days with no activity and no assignee. It will be closed in 7 days unless a comment is added.

from kpatch.

This issue was closed because it was inactive for 7 days after being marked stale.

from kpatch.

This issue has been open for 30 days with no activity and no assignee. It will be closed in 7 days unless a comment is added.

from kpatch.

This issue was closed because it was inactive for 7 days after being marked stale.

from kpatch.